-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the new logic for alignwide and alignfull #4
Comments
I give up for tonight. Tomorrow have a look at WordPress/theme-experiments#234. Maybe the Site Editor's hasn't been updated so I'll need to edit the templates and template parts manually. |
It looks like you aren't running the latest version of the Gutenberg plugin. You'll need to be using the latest version of |
We'll have to write a lot more docs about this functionality, it's still very early and being proved. Judging by your screenshot if you want to define a global "layout" config that is used in the post editor and that can be "inherited" in the site editor containers, you'll have to define it in your |
@scruffian I was using the latest build, just bad JSON. See the second screenshot in #5 (comment) Here's the latest screenshot for the front end, with the And here's the results with the background colour on the group block removed... the group block wasn't filling the whole of the window width. Is this expected? Structure of this "Footer" template part is
Looks like I need guidance on how to set the Layout options for the Template part and Group. |
So having resolved the Tag cloud problem - a temporary fix applied to stop wpautop() from running on template parts - I've now changed the align attribute on the columns block in the footer, template part It's looking better. Here's a diff of the relevant changes.
Interpret this diff output as:
Maybe I don't need the Group block any more! Note: You can't really tell in the Site Editor whether or not what you want is what you're going to get. |
I think the problem comes down to understanding the "layout" feature, the documentation is not yet there. If I had to define it it's something like:
|
thanks. |
…gn-wide') to use the new declarative method
I'm not going to close this yet. |
Still leaving this open even though I've delivered v0.2.1. |
In WordPress/gutenberg#29335 a solution has been developed that make alignments more declarative.
ie A new solution makes it a lot easier to use
alignwide
andalignfull
. I believe this means you no longer need a ton of confusing CSS.Since SB is a brand new theme I feel I should implement the solution in this theme first.
Later, when comfortable with the solution, and when a run time version of Gutenberg is delivered, I should apply it to Fizzie as well. See http://github.com/bobbingwide/fizzies/issues/44
Requirements
As for Fizzie. Properly support alignwide and alignfull, but with widths as below
Solution
experimental-theme.json
replacing "custom" with "layout"Which is basically the same as for WordPress/theme-experiments#233
Caveat
I don't know what to expect with the sidebar.
The text was updated successfully, but these errors were encountered: