-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some panics related to BigInt operations #884
Conversation
Codecov Report
@@ Coverage Diff @@
## master #884 +/- ##
==========================================
+ Coverage 59.30% 59.43% +0.13%
==========================================
Files 165 165
Lines 10342 10399 +57
==========================================
+ Hits 6133 6181 +48
- Misses 4209 4218 +9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good, thanks!
This should fix the panics from #883. However, I'm not very sure if this is the right way to do it or if there is a better way to generate errors instead of panicking, so I would appreciate some feedback on it.