Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some panics related to BigInt operations #884

Merged
merged 3 commits into from
Oct 18, 2020
Merged

Fix some panics related to BigInt operations #884

merged 3 commits into from
Oct 18, 2020

Conversation

georgeroman
Copy link
Contributor

This should fix the panics from #883. However, I'm not very sure if this is the right way to do it or if there is a better way to generate errors instead of panicking, so I would appreciate some feedback on it.

@codecov
Copy link

codecov bot commented Oct 16, 2020

Codecov Report

Merging #884 into master will increase coverage by 0.13%.
The diff coverage is 63.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #884      +/-   ##
==========================================
+ Coverage   59.30%   59.43%   +0.13%     
==========================================
  Files         165      165              
  Lines       10342    10399      +57     
==========================================
+ Hits         6133     6181      +48     
- Misses       4209     4218       +9     
Impacted Files Coverage Δ
boa/src/value/operations.rs 47.74% <40.00%> (+1.00%) ⬆️
boa/src/builtins/bigint/mod.rs 70.14% <84.61%> (+6.81%) ⬆️
boa/src/builtins/bigint/operations.rs 85.71% <88.23%> (+30.87%) ⬆️
boa/src/object/gcobject.rs 65.60% <0.00%> (-7.64%) ⬇️
boa/src/builtins/object/mod.rs 64.00% <0.00%> (-0.87%) ⬇️
boa/src/builtins/json/mod.rs 82.05% <0.00%> (-0.85%) ⬇️
boa/src/object/mod.rs 46.45% <0.00%> (-0.54%) ⬇️
boa/src/value/display.rs 88.50% <0.00%> (-0.14%) ⬇️
boa/src/context.rs 61.64% <0.00%> (+0.55%) ⬆️
boa/src/value/mod.rs 74.58% <0.00%> (+0.80%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc1628a...8a108eb. Read the comment docs.

@HalidOdat HalidOdat added bug Something isn't working execution Issues or PRs related to code execution labels Oct 17, 2020
@HalidOdat HalidOdat added this to the v0.11.0 milestone Oct 17, 2020
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, thanks!

@Razican Razican merged commit f2f2153 into boa-dev:master Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working execution Issues or PRs related to code execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants