-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Object.getOwnPropertyDescriptor() and Object.getOwnPropertyDescriptors() #798
Implement Object.getOwnPropertyDescriptor() and Object.getOwnPropertyDescriptors() #798
Conversation
Codecov Report
@@ Coverage Diff @@
## master #798 +/- ##
==========================================
- Coverage 59.37% 59.29% -0.08%
==========================================
Files 157 157
Lines 10036 10078 +42
==========================================
+ Hits 5959 5976 +17
- Misses 4077 4102 +25
Continue to review full report at Codecov.
|
Hey @JohnDoneth, there is a conflict could you rebase this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Check my comments about the documentation, I think it's best if we use the rolling spec, and we need to fix a link at least.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
It changes the following:
Object.getOwnPropertyDescriptor( object, property )
andObject.getOwnPropertyDescriptors( object )