Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Object.is() method issue #513 #515

Merged
merged 4 commits into from
Jun 21, 2020
Merged

Implement Object.is() method issue #513 #515

merged 4 commits into from
Jun 21, 2020

Conversation

tylermorten
Copy link

This Pull Request fixes/closes #513.

It changes the following:

  • Implements Object.is() method per issue request specs (w/o strict ?).
  • Adds unit test for example code.

@codecov
Copy link

codecov bot commented Jun 20, 2020 •
edited
Loading

Codecov Report

Merging #515 into master will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #515      +/-   ##
==========================================
+ Coverage   67.73%   67.86%   +0.12%     
==========================================
  Files         165      165              
  Lines        9933     9954      +21     
==========================================
+ Hits         6728     6755      +27     
+ Misses       3205     3199       -6
Impacted Files Coverage Δ
boa/src/builtins/object/mod.rs 37.11% <100.00%> (+2.00%) ⬆️
boa/src/builtins/object/tests.rs 100.00% <100.00%> (ø)
boa/src/builtins/value/equality.rs 73.17% <0.00%> (+7.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 299a431...fc169a9. Read the comment docs.

HalidOdat
HalidOdat reviewed Jun 20, 2020
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! check my comments :)

boa/src/builtins/object/mod.rs Outdated Show resolved Hide resolved
boa/src/builtins/object/mod.rs Outdated Show resolved Hide resolved
@HalidOdat HalidOdat added builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request labels Jun 20, 2020
@HalidOdat HalidOdat added this to the v0.9.0 milestone Jun 20, 2020
@tylermorten
Copy link
Author

Got it- I'm on it. Should have seen that same_value does everything I needed it to do :)

HalidOdat
HalidOdat reviewed Jun 20, 2020
View reviewed changes
boa/src/builtins/object/mod.rs Outdated Show resolved Hide resolved
boa/src/builtins/object/mod.rs Show resolved Hide resolved
HalidOdat
HalidOdat approved these changes Jun 20, 2020
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect! :)

@HalidOdat HalidOdat merged commit 1ffeb5c into boa-dev:master Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HalidOdat HalidOdat HalidOdat approved these changes

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@Razican Razican Awaiting requested review from Razican

Assignees
No one assigned
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.

Implement Object.is() method
2 participants
@tylermorten @HalidOdat