Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added String, Boolean and Number object benchmarks #494

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

HalidOdat
Copy link
Member

No description provided.

@HalidOdat HalidOdat added benchmark Issues and PRs related to the benchmark subsystem. enhancement New feature or request execution Issues or PRs related to code execution labels Jun 15, 2020
@HalidOdat HalidOdat marked this pull request as ready for review June 15, 2020 03:24
@HalidOdat HalidOdat added this to the v0.9.0 milestone Jun 15, 2020
@codecov
Copy link

codecov bot commented Jun 15, 2020

Codecov Report

Merging #494 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #494   +/-   ##
=======================================
  Coverage   67.51%   67.51%           
=======================================
  Files         155      155           
  Lines        9719     9719           
=======================================
  Hits         6562     6562           
  Misses       3157     3157           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2939ff...6cf7849. Read the comment docs.

@HalidOdat HalidOdat mentioned this pull request Jun 15, 2020
8 tasks
@HalidOdat
Copy link
Member Author

HalidOdat commented Jun 15, 2020

It seems criterion-comapare-action is failing with message 😕

TypeError: Cannot read property 'split' of undefined

@Razican
Copy link
Member

Razican commented Jun 15, 2020

It seems criterion-comapare-action is failing with message 😕

TypeError: Cannot read property 'split' of undefined

Yep, this happens with new benchmarks. There is a PR in the repo that solves it.

@HalidOdat
Copy link
Member Author

I'm re-running the benchmarks :)

@HalidOdat
Copy link
Member Author

Another error criterion-comapare-action:

ReferenceError: difference is not defined

@github-actions
Copy link

Benchmark for 38c2dc8

Click to view benchmark
Test PR Benchmark Master Benchmark %
Array access (Execution) 38.1±3.20µs 37.0±3.04µs +2.97%
Array creation (Execution) 15.4±0.72ms 14.8±0.76ms +4.05%
Array pop (Execution) 9.1±0.53ms 8.9±0.61ms +2.25%
Boolean Object Access (Execution) 32.2±3.31µs N/A N/A
Create Realm 521.6±52.10µs 492.3±44.71µs +5.95%
Dynamic Object Property Access (Execution) 18.1±1.88µs 17.8±1.25µs +1.69%
Expression (Lexer) 2.1±0.17µs 2.2±0.15µs -4.55%
Expression (Parser) 4.8±0.40µs 5.1±0.51µs -5.88%
Fibonacci (Execution) 2.2±0.15ms 2.2±0.19ms 0.00%
For loop (Execution) 71.8±7.05µs 68.7±6.26µs +4.51%
For loop (Lexer) 5.2±0.34µs 5.5±0.49µs -5.45%
For loop (Parser) 13.9±1.25µs 14.0±1.23µs -0.71%
Hello World (Lexer) 983.1±76.74ns 1003.1±80.58ns -1.99%
Hello World (Parser) 2.2±0.23µs 2.3±0.23µs -4.35%
Long file (Parser) 6.2±0.42ms 6.3±0.49ms -1.59%
Number Object Access (Execution) 27.4±2.59µs N/A N/A
Object Creation (Execution) 15.5±1.36µs 15.9±0.87µs -2.52%
RegExp (Execution) 90.6±8.77µs 90.8±7.68µs -0.22%
RegExp Literal (Execution) 99.5±8.47µs 100.7±7.91µs -1.19%
RegExp Literal Creation (Execution) 92.8±7.78µs 90.8±6.18µs +2.20%
Static Object Property Access (Execution) 16.5±1.66µs 17.4±2.06µs -5.17%
String Object Access (Execution) 48.1±4.23µs N/A N/A
String comparison (Execution) 20.4±1.59µs 20.2±1.85µs +0.99%
String concatenation (Execution) 16.0±1.48µs 16.8±1.46µs -4.76%
String copy (Execution) 13.3±1.36µs 13.6±1.17µs -2.21%
Symbols (Execution) 18.2±1.81µs 18.6±2.25µs -2.15%

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go from my side :) great to have more benchmarks!!

@HalidOdat HalidOdat merged commit 0d52a40 into master Jun 15, 2020
@HalidOdat HalidOdat deleted the specialized-objects-benchmarks branch June 15, 2020 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Issues and PRs related to the benchmark subsystem. enhancement New feature or request execution Issues or PRs related to code execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants