Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RegExp v flag #3695

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Implement RegExp v flag #3695

merged 1 commit into from
Feb 27, 2024

Conversation

raskad
Copy link
Member

@raskad raskad commented Feb 26, 2024

This PR updates regress to v0.9.0, adding support for the v flag.

@raskad raskad added enhancement New feature or request builtins PRs and Issues related to builtins/intrinsics labels Feb 26, 2024
@raskad raskad added this to the v0.18.0 milestone Feb 26, 2024
@raskad raskad requested a review from a team February 26, 2024 23:59
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 50,268 50,268 0
Passed 42,547 42,725 +178
Ignored 1,570 1,391 -179
Failed 6,151 6,152 +1
Panics 0 0 0
Conformance 84.64% 84.99% +0.35%
Fixed tests (178):
test/built-ins/RegExp/property-escapes/generated/strings/Basic_Emoji-negative-u.js (previously Ignored)
test/built-ins/RegExp/property-escapes/generated/strings/RGI_Emoji_ZWJ_Sequence-negative-u.js (previously Ignored)
test/built-ins/RegExp/property-escapes/generated/strings/RGI_Emoji_Tag_Sequence.js (previously Ignored)
test/built-ins/RegExp/property-escapes/generated/strings/Emoji_Keycap_Sequence-negative-CharacterClass.js (previously Ignored)
test/built-ins/RegExp/property-escapes/generated/strings/RGI_Emoji_Flag_Sequence-negative-P.js (previously Ignored)
test/built-ins/RegExp/property-escapes/generated/strings/RGI_Emoji_Tag_Sequence-negative-u.js (previously Ignored)
test/built-ins/RegExp/property-escapes/generated/strings/RGI_Emoji_Modifier_Sequence-negative-P.js (previously Ignored)
test/built-ins/RegExp/property-escapes/generated/strings/RGI_Emoji_Tag_Sequence-negative-CharacterClass.js (previously Ignored)
test/built-ins/RegExp/property-escapes/generated/strings/RGI_Emoji_ZWJ_Sequence-negative-CharacterClass.js (previously Ignored)
test/built-ins/RegExp/property-escapes/generated/strings/Emoji_Keycap_Sequence.js (previously Ignored)
test/built-ins/RegExp/property-escapes/generated/strings/RGI_Emoji.js (previously Ignored)
test/built-ins/RegExp/property-escapes/generated/strings/RGI_Emoji_ZWJ_Sequence-negative-P.js (previously Ignored)
test/built-ins/RegExp/property-escapes/generated/strings/Basic_Emoji.js (previously Ignored)
test/built-ins/RegExp/property-escapes/generated/strings/RGI_Emoji-negative-CharacterClass.js (previously Ignored)
test/built-ins/RegExp/property-escapes/generated/strings/RGI_Emoji_Flag_Sequence-negative-u.js (previously Ignored)
test/built-ins/RegExp/property-escapes/generated/strings/RGI_Emoji_Modifier_Sequence-negative-CharacterClass.js (previously Ignored)
test/built-ins/RegExp/property-escapes/generated/strings/Basic_Emoji-negative-P.js (previously Ignored)
test/built-ins/RegExp/property-escapes/generated/strings/Emoji_Keycap_Sequence-negative-P.js (previously Ignored)
test/built-ins/RegExp/property-escapes/generated/strings/RGI_Emoji-negative-P.js (previously Ignored)
test/built-ins/RegExp/property-escapes/generated/strings/RGI_Emoji_Modifier_Sequence.js (previously Ignored)
test/built-ins/RegExp/property-escapes/generated/strings/RGI_Emoji_ZWJ_Sequence.js (previously Ignored)
test/built-ins/RegExp/property-escapes/generated/strings/Basic_Emoji-negative-CharacterClass.js (previously Ignored)
test/built-ins/RegExp/property-escapes/generated/strings/RGI_Emoji-negative-u.js (previously Ignored)
test/built-ins/RegExp/property-escapes/generated/strings/Emoji_Keycap_Sequence-negative-u.js (previously Ignored)
test/built-ins/RegExp/property-escapes/generated/strings/RGI_Emoji_Flag_Sequence-negative-CharacterClass.js (previously Ignored)
test/built-ins/RegExp/property-escapes/generated/strings/RGI_Emoji_Flag_Sequence.js (previously Ignored)
test/built-ins/RegExp/property-escapes/generated/strings/RGI_Emoji_Modifier_Sequence-negative-u.js (previously Ignored)
test/built-ins/RegExp/property-escapes/generated/strings/RGI_Emoji_Tag_Sequence-negative-P.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-difference-property-of-strings-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-class-difference-character-property-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-difference-character.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-union-character.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-class-escape-union-character-class-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/property-of-strings-escape-intersection-property-of-strings-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-union-property-of-strings-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/string-literal-union-character-property-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-property-escape-intersection-character-class-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-class-escape-difference-character.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-property-escape-union-property-of-strings-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/property-of-strings-escape-intersection-string-literal.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/string-literal-difference-string-literal.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/property-of-strings-escape-union-character.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-property-escape-union-character-property-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-union-string-literal.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-class-escape-intersection-character-class.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-class-escape-intersection-property-of-strings-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-class-escape-difference-character-class.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-intersection-property-of-strings-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-class-escape-union-string-literal.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-property-escape-intersection-string-literal.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/string-literal-difference-character-class.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-property-escape-difference-character-class-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/property-of-strings-escape-intersection-character-class.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-class-escape-union-property-of-strings-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-property-escape-union-character-class-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-class-difference-string-literal.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-property-escape-union-character.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/property-of-strings-escape-difference-character.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-class-difference-character.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-property-escape-difference-string-literal.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/string-literal-intersection-character-class-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-class-escape-difference-string-literal.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/property-of-strings-escape-union-property-of-strings-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/property-of-strings-escape-intersection-character-property-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/property-of-strings-escape-difference-character-property-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-class-intersection-character.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-class-escape-difference-character-class-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-class-union-character-class.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/property-of-strings-escape-union-character-class.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-class-escape-union-character-class.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/string-literal-union-property-of-strings-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-intersection-character-class.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/string-literal-intersection-character-class.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-class-union-character.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/string-literal-difference-character-property-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-class-difference-character-class-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/property-of-strings-escape-difference-property-of-strings-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-intersection-string-literal.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-class-escape-union-character-property-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-intersection-character-class-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-class-escape-difference-character-property-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-property-escape-difference-character.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-union-character-class-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-difference-string-literal.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-class-union-character-class-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-class-difference-property-of-strings-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-property-escape-difference-property-of-strings-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/string-literal-union-string-literal.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/property-of-strings-escape-union-character-property-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/string-literal-union-character-class.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-difference-character-property-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-class-intersection-character-class.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-intersection-character.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/string-literal-union-character-class-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/property-of-strings-escape-union-character-class-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-property-escape-difference-character-property-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-class-escape-intersection-string-literal.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-property-escape-intersection-property-of-strings-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/property-of-strings-escape-intersection-character-class-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-class-intersection-character-class-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/string-literal-intersection-property-of-strings-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-intersection-character-property-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/property-of-strings-escape-intersection-character.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-property-escape-union-string-literal.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/string-literal-difference-character.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-class-intersection-property-of-strings-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-property-escape-difference-character-class.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/string-literal-intersection-character.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/string-literal-difference-property-of-strings-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-class-intersection-string-literal.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-class-intersection-character-property-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-class-escape-union-character.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-difference-character-class.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-class-union-character-property-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/rgi-emoji-14.0.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-property-escape-intersection-character.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/property-of-strings-escape-difference-string-literal.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/property-of-strings-escape-difference-character-class-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-property-escape-intersection-character-property-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/rgi-emoji-15.0.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-property-escape-intersection-character-class.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/string-literal-intersection-character-property-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-class-union-string-literal.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-difference-character-class-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-union-character-property-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-union-character-class.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-property-escape-union-character-class.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/rgi-emoji-13.1.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-class-escape-difference-property-of-strings-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-class-escape-intersection-character-property-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-class-escape-intersection-character-class-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/string-literal-intersection-string-literal.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-class-difference-character-class.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/string-literal-union-character.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/property-of-strings-escape-union-string-literal.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-class-union-property-of-strings-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/character-class-escape-intersection-character.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/string-literal-difference-character-class-escape.js (previously Ignored)
test/built-ins/RegExp/unicodeSets/generated/property-of-strings-escape-difference-character-class.js (previously Ignored)
test/built-ins/RegExp/prototype/flags/this-val-regexp.js (previously Ignored)
test/built-ins/RegExp/prototype/unicodeSets/breaking-change-from-u-to-v-02.js (previously Ignored)
test/built-ins/RegExp/prototype/unicodeSets/this-val-invalid-obj.js (previously Ignored)
test/built-ins/RegExp/prototype/unicodeSets/breaking-change-from-u-to-v-01.js (previously Ignored)
test/built-ins/RegExp/prototype/unicodeSets/breaking-change-from-u-to-v-20.js (previously Ignored)
test/built-ins/RegExp/prototype/unicodeSets/breaking-change-from-u-to-v-12.js (previously Ignored)
test/built-ins/RegExp/prototype/unicodeSets/breaking-change-from-u-to-v-08.js (previously Ignored)
test/built-ins/RegExp/prototype/unicodeSets/breaking-change-from-u-to-v-13.js (previously Ignored)
test/built-ins/RegExp/prototype/unicodeSets/breaking-change-from-u-to-v-27.js (previously Ignored)
test/built-ins/RegExp/prototype/unicodeSets/breaking-change-from-u-to-v-26.js (previously Ignored)
test/built-ins/RegExp/prototype/unicodeSets/breaking-change-from-u-to-v-10.js (previously Ignored)
test/built-ins/RegExp/prototype/unicodeSets/breaking-change-from-u-to-v-22.js (previously Ignored)
test/built-ins/RegExp/prototype/unicodeSets/name.js (previously Ignored)
test/built-ins/RegExp/prototype/unicodeSets/breaking-change-from-u-to-v-03.js (previously Ignored)
test/built-ins/RegExp/prototype/unicodeSets/this-val-regexp.js (previously Ignored)
test/built-ins/RegExp/prototype/unicodeSets/breaking-change-from-u-to-v-23.js (previously Ignored)
test/built-ins/RegExp/prototype/unicodeSets/this-val-regexp-prototype.js (previously Ignored)
test/built-ins/RegExp/prototype/unicodeSets/cross-realm.js (previously Ignored)
test/built-ins/RegExp/prototype/unicodeSets/breaking-change-from-u-to-v-07.js (previously Ignored)
test/built-ins/RegExp/prototype/unicodeSets/length.js (previously Ignored)
test/built-ins/RegExp/prototype/unicodeSets/breaking-change-from-u-to-v-09.js (previously Ignored)
test/built-ins/RegExp/prototype/unicodeSets/prop-desc.js (previously Ignored)
test/built-ins/RegExp/prototype/unicodeSets/breaking-change-from-u-to-v-11.js (previously Ignored)
test/built-ins/RegExp/prototype/unicodeSets/breaking-change-from-u-to-v-21.js (previously Ignored)
test/built-ins/RegExp/prototype/unicodeSets/breaking-change-from-u-to-v-17.js (previously Ignored)
test/built-ins/RegExp/prototype/unicodeSets/breaking-change-from-u-to-v-06.js (previously Ignored)
test/built-ins/RegExp/prototype/unicodeSets/breaking-change-from-u-to-v-28.js (previously Ignored)
test/built-ins/RegExp/prototype/unicodeSets/breaking-change-from-u-to-v-18.js (previously Ignored)
test/built-ins/RegExp/prototype/unicodeSets/breaking-change-from-u-to-v-14.js (previously Ignored)
test/built-ins/RegExp/prototype/unicodeSets/breaking-change-from-u-to-v-25.js (previously Ignored)
test/built-ins/RegExp/prototype/unicodeSets/breaking-change-from-u-to-v-05.js (previously Ignored)
test/built-ins/RegExp/prototype/unicodeSets/uv-flags-constructor.js (previously Ignored)
test/built-ins/RegExp/prototype/unicodeSets/breaking-change-from-u-to-v-19.js (previously Ignored)
test/built-ins/RegExp/prototype/unicodeSets/breaking-change-from-u-to-v-04.js (previously Ignored)
test/built-ins/RegExp/prototype/unicodeSets/uv-flags.js (previously Ignored)
test/built-ins/RegExp/prototype/unicodeSets/this-val-non-obj.js (previously Ignored)
test/built-ins/RegExp/prototype/unicodeSets/breaking-change-from-u-to-v-16.js (previously Ignored)
test/built-ins/RegExp/prototype/unicodeSets/breaking-change-from-u-to-v-24.js (previously Ignored)
test/built-ins/RegExp/prototype/unicodeSets/breaking-change-from-u-to-v-15.js (previously Ignored)

@nekevss nekevss requested a review from a team February 27, 2024 01:59
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive work! Really liking that regress' development is progressing so fast.

@jedel1043 jedel1043 added this pull request to the merge queue Feb 27, 2024
Merged via the queue into main with commit a7c2f5b Feb 27, 2024
13 checks passed
@raskad raskad deleted the regexp-v-flag branch February 27, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants