Allow awaiting JsPromise from Rust code
#3011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test262 conformance changes
|
Codecov Report
@@ Coverage Diff @@
## main #3011 +/- ##
==========================================
- Coverage 50.56% 50.50% -0.06%
==========================================
Files 446 446
Lines 45902 46008 +106
==========================================
+ Hits 23210 23236 +26
- Misses 22692 22772 +80
|
Razican
approved these changes
Jun 17, 2023
There was a problem hiding this comment.
Looking great! I added a couple of suggestions for two doc links. We might want to mention this in boa-dev/boa-dev.github.io#94
Razican
pushed a commit
that referenced
this pull request
Jun 26, 2023
* Allow awaiting `JsPromise` from Rust code * Fix docs * Relink to docs.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be mostly useful for consumers of the
JobQueue::enqueue_future_jobAPI, since they can now await for certain promises insideasyncblocks and functions.Changes:
JsFuturetype that implementsFuture.JsPromise::into_js_futuremethod.NativeFunction::from_async_fn, since the old explanation was wrong.JsPromise::from_futureconstructor.