[Merged by Bors] - Implement host hooks and job queues APIs #2529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedel1043
added
enhancement
jedel1043
requested review from
Razican,
jasonwilliams,
HalidOdat,
RageKnify,
raskad and
nekevss
Test262 conformance changes
|
Benchmark for 754d5b9Click to view benchmark
|
|
I thought a bit more about the design of this and I think I can unify the three lifetimes into only one with some lifetime trickery, making this PR a lot more lightweight! I'll make the fix today. |
jedel1043
force-pushed
the
host-callbacks
branch
from
1a1d18b to
868705a
Compare
Codecov Report
@@ Coverage Diff @@
## main #2529 +/- ##
==========================================
+ Coverage 49.92% 51.07% +1.14%
==========================================
Files 377 374 -3
Lines 37557 36796 -761
==========================================
+ Hits 18751 18793 +42
+ Misses 18806 18003 -803
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nekevss
reviewed
Jan 12, 2023
|
👀 |
jedel1043
force-pushed
the
host-callbacks
branch
from
c80e504 to
c537689
Compare
raskad
reviewed
Jan 17, 2023
raskad
approved these changes
Jan 17, 2023
jedel1043
force-pushed
the
host-callbacks
branch
from
c537689 to
0f76a12
Compare
HalidOdat
approved these changes
Jan 19, 2023
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Jan 19, 2023
Follows from #2528, and should complement #2411 to implement the module import hooks. ~~Similarly to the Intl/ICU4X PR (#2478), this has a lot of trivial changes caused by the new lifetimes. I thought about passing the queue and the hooks by value, but it was very painful having to wrap everything with `Rc` in order to be accessible by the host. In contrast, `&dyn` can be easily provided by the host and has the advantage of not requiring additional allocations, with the downside of adding two more lifetimes to our `Context`, but I think it's worth.~~ I was able to unify all lifetimes into the shortest one of the three, making our API just like before! Changes: - Added a new `HostHooks` trait and a `&dyn HostHooks` field to `Context`. This allows hosts to implement the trait for their custom type, then pass it to the context. - Added a new `JobQueue` trait and a `&dyn JobQueue` field to our `Context`, allowing custom event loops and other fun things. - Added two simple implementations of `JobQueue`: `IdleJobQueue` which does nothing and `SimpleJobQueue` which runs all jobs until all successfully complete or until any of them throws an error. - Modified `boa_cli` to run all jobs until the queue is empty, even if a job returns `Err`. This also prints all errors to the user.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
bors bot
pushed a commit
that referenced
this pull request
Feb 24, 2023
~~Builds off of #2529.~~ Merged. This Pull Request allows passing any function returning `impl Future<Output = JsResult<JsValue>>` to the `NativeFunction` constructor, allowing native concurrency hooks into the engine. It changes the following: - Adds a `NativeFunction::from_async_fn` function. - Adds a new `JobQueue::enqueue_future_job` method. - Adds an example usage on `boa_examples`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows from #2528, and should complement #2411 to implement the module import hooks.
Similarly to the Intl/ICU4X PR (#2478), this has a lot of trivial changes caused by the new lifetimes. I thought about passing the queue and the hooks by value, but it was very painful having to wrap everything withI was able to unify all lifetimes into the shortest one of the three, making our API just like before!Rcin order to be accessible by the host.In contrast,
&dyncan be easily provided by the host and has the advantage of not requiring additional allocations, with the downside of adding two more lifetimes to ourContext, but I think it's worth.Changes:
HostHookstrait and a&dyn HostHooksfield toContext. This allows hosts to implement the trait for their custom type, then pass it to the context.JobQueuetrait and a&dyn JobQueuefield to ourContext, allowing custom event loops and other fun things.JobQueue:IdleJobQueuewhich does nothing andSimpleJobQueuewhich runs all jobs until all successfully complete or until any of them throws an error.boa_clito run all jobs until the queue is empty, even if a job returnsErr. This also prints all errors to the user.