-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Fix some Date tests #2431
Conversation
Test262 conformance changes
Fixed tests (22):
|
Codecov Report
@@ Coverage Diff @@
## main #2431 +/- ##
==========================================
- Coverage 38.86% 38.85% -0.01%
==========================================
Files 316 316
Lines 24131 24123 -8
==========================================
- Hits 9378 9374 -4
+ Misses 14753 14749 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :) thank you! We should probably add more inline comments with the statements from the spec, but they were not there before most of the times, so we can merge it as-is.
I have marked one of the functions, but there are more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect to me :)
bors r+ |
Found some tests on the `Date` builtin that were failing for incorrect length attributes and missing checks.
Pull request successfully merged into main. Build succeeded: |
Found some tests on the
Date
builtin that were failing for incorrect length attributes and missing checks.