Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix some Date tests #2431

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Fix some Date tests #2431

wants to merge 2 commits into from

Conversation

jedel1043
Copy link
Member

Found some tests on the Date builtin that were failing for incorrect length attributes and missing checks.

@jedel1043 jedel1043 added enhancement New feature or request builtins PRs and Issues related to builtins/intrinsics labels Nov 11, 2022
@jedel1043 jedel1043 added this to the v0.17.0 milestone Nov 11, 2022
@github-actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 93,815 93,815 0
Passed 69,540 69,562 +22
Ignored 18,422 18,422 0
Failed 5,853 5,831 -22
Panics 0 0 0
Conformance 74.12% 74.15% +0.02%
Fixed tests (22):
test/intl402/Date/prototype/toLocaleTimeString/length.js [strict mode] (previously Failed)
test/intl402/Date/prototype/toLocaleTimeString/length.js (previously Failed)
test/intl402/Date/prototype/toLocaleDateString/length.js [strict mode] (previously Failed)
test/intl402/Date/prototype/toLocaleDateString/length.js (previously Failed)
test/intl402/Date/prototype/toLocaleString/length.js [strict mode] (previously Failed)
test/intl402/Date/prototype/toLocaleString/length.js (previously Failed)
test/built-ins/Date/prototype/setTime/this-value-valid-date.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setTime/this-value-valid-date.js (previously Failed)
test/built-ins/Date/prototype/setTime/this-value-invalid-date.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setTime/this-value-invalid-date.js (previously Failed)
test/built-ins/Date/prototype/setTime/new-value-time-clip.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setTime/new-value-time-clip.js (previously Failed)
test/built-ins/Date/prototype/setTime/arg-to-number.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/setTime/arg-to-number.js (previously Failed)
test/built-ins/Date/prototype/toLocaleTimeString/S15.9.5.7_A2_T1.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/toLocaleTimeString/S15.9.5.7_A2_T1.js (previously Failed)
test/built-ins/Date/prototype/toUTCString/invalid-date.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/toUTCString/invalid-date.js (previously Failed)
test/built-ins/Date/prototype/toLocaleDateString/S15.9.5.6_A2_T1.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/toLocaleDateString/S15.9.5.6_A2_T1.js (previously Failed)
test/built-ins/Date/prototype/toLocaleString/S15.9.5.5_A2_T1.js [strict mode] (previously Failed)
test/built-ins/Date/prototype/toLocaleString/S15.9.5.5_A2_T1.js (previously Failed)

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #2431 (fa700c7) into main (2362f73) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #2431      +/-   ##
==========================================
- Coverage   38.86%   38.85%   -0.01%     
==========================================
  Files         316      316              
  Lines       24131    24123       -8     
==========================================
- Hits         9378     9374       -4     
+ Misses      14753    14749       -4     
Impacted Files Coverage Δ
boa_engine/src/value/mod.rs 50.36% <0.00%> (-0.17%) ⬇️
boa_engine/src/builtins/date/mod.rs 86.39% <66.66%> (+0.12%) ⬆️
boa_engine/src/value/integer.rs 69.23% <80.00%> (+6.73%) ⬆️
boa_engine/src/builtins/error/range.rs 100.00% <0.00%> (ø)
boa_engine/src/context/mod.rs 35.00% <0.00%> (+0.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :) thank you! We should probably add more inline comments with the statements from the spec, but they were not there before most of the times, so we can merge it as-is.

I have marked one of the functions, but there are more.

boa_engine/src/builtins/date/mod.rs Show resolved Hide resolved
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me :)

@HalidOdat
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Nov 11, 2022
Found some tests on the `Date` builtin that were failing for incorrect length attributes and missing checks.
@bors
Copy link

bors bot commented Nov 11, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Fix some Date tests [Merged by Bors] - Fix some Date tests Nov 11, 2022
@bors bors bot closed this Nov 11, 2022
@bors bors bot deleted the date-fix branch November 11, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants