Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Implement JsGenerator and wrapper docs clean up #2380

Closed
wants to merge 2 commits into from

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Oct 25, 2022

This Pull Request is related to #2098.

It changes the following:

  • Implements a wrapper for the Generator built-in object
  • Adds to some of the documentation across the builtin wrappers with the goal of trying to clean up the documentation by making it a bit more consistent on boa's docs

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #2380 (63638b4) into main (48e6513) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2380      +/-   ##
==========================================
- Coverage   39.89%   39.83%   -0.06%     
==========================================
  Files         304      305       +1     
  Lines       23332    23359      +27     
==========================================
- Hits         9308     9305       -3     
- Misses      14024    14054      +30     
Impacted Files Coverage Δ
boa_engine/src/object/builtins/jsarray.rs 5.05% <ø> (ø)
boa_engine/src/object/builtins/jsarraybuffer.rs 0.00% <ø> (ø)
boa_engine/src/object/builtins/jsdataview.rs 0.00% <ø> (ø)
boa_engine/src/object/builtins/jsfunction.rs 40.00% <ø> (ø)
boa_engine/src/object/builtins/jsgenerator.rs 0.00% <0.00%> (ø)
boa_engine/src/object/builtins/jsmap.rs 0.00% <ø> (ø)
boa_engine/src/object/builtins/jsmap_iterator.rs 0.00% <ø> (ø)
boa_engine/src/object/builtins/jsproxy.rs 0.00% <ø> (ø)
boa_engine/src/object/builtins/jsregexp.rs 0.00% <ø> (ø)
boa_engine/src/object/builtins/jsset.rs 0.00% <ø> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! Looks good :)

@raskad
Copy link
Member

raskad commented Oct 26, 2022

bors r+

bors bot pushed a commit that referenced this pull request Oct 26, 2022
<!---
Thank you for contributing to Boa! Please fill out the template below, and remove or add any
information as you feel necessary.
--->

This Pull Request is related to #2098.

It changes the following:

- Implements a wrapper for the `Generator` built-in object
- Adds to some of the documentation across the builtin wrappers with the goal of trying to clean up the documentation by making it a bit more consistent [on boa's docs](https://boa-dev.github.io/boa/doc/boa_engine/object/builtins/index.html)
@bors
Copy link

bors bot commented Oct 26, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Implement JsGenerator and wrapper docs clean up [Merged by Bors] - Implement JsGenerator and wrapper docs clean up Oct 26, 2022
@bors bors bot closed this Oct 26, 2022
@RageKnify RageKnify added the enhancement New feature or request label Nov 9, 2022
@RageKnify RageKnify added this to the v0.17.0 milestone Nov 9, 2022
@RageKnify RageKnify added the documentation update documentation label Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation update documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants