-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Implement Promise.all
#2140
Conversation
Test262 conformance changesVM implementation
Fixed tests (166):
|
Codecov Report
@@ Coverage Diff @@
## main #2140 +/- ##
==========================================
- Coverage 43.52% 43.41% -0.12%
==========================================
Files 220 220
Lines 20028 20079 +51
==========================================
Hits 8717 8717
- Misses 11311 11362 +51
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect to me! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
I'm happy to merge it from my side, but I'd like to point out a potential performance optimization. Give it a look, and if it makes sense, feel free to implement it and merge.
bors r+ |
Pull request successfully merged into main. Build succeeded: |
Promise.all
Promise.all
This Pull Request changes the following:
Promise.all