Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - cargo workspaces fixes #2001 #2026

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - cargo workspaces fixes #2001 #2026

wants to merge 1 commit into from

Conversation

jasonwilliams
Copy link
Member

@jasonwilliams jasonwilliams commented Apr 12, 2022 •
edited
Loading

This adds cargo-workspaces to our repo for easier publishing.
(I think we may need to do a dry run of this first to test)

fixes #2001

@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #2026 (9df8c44) into main (34303f1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2026   +/-   ##
=======================================
  Coverage   44.15%   44.15%           
=======================================
  Files         210      210           
  Lines       18596    18596           
=======================================
  Hits         8211     8211           
  Misses      10385    10385

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34303f1...9df8c44. Read the comment docs.

raskad
raskad approved these changes Apr 14, 2022
View reviewed changes
Copy link
Member

@raskad raskad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me in theory. I agree we should try a dry run somehow

Razican
Razican approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we'll have to test it in the next release :)

@Razican
Copy link
Member

Razican commented Apr 26, 2022

bors r+

bors bot pushed a commit that referenced this pull request Apr 26, 2022
@jasonwilliams
cargo workspaces fixes #2001 (#2026)
01bd50f 
This adds cargo-workspaces to our repo for easier publishing. 
(I think we may need to do a dry run of this first to test)

fixes #2001
@bors
Copy link

bors bot commented Apr 26, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title cargo workspaces fixes #2001 [Merged by Bors] - cargo workspaces fixes #2001 Apr 26, 2022
@bors bors bot closed this Apr 26, 2022
@Razican Razican added this to the v0.15.0 milestone Jun 1, 2022
@Razican Razican added the enhancement New feature or request label Jun 1, 2022
Razican pushed a commit that referenced this pull request Jun 8, 2022
@jasonwilliams @Razican
cargo workspaces fixes #2001 (#2026)
5c71f90 
This adds cargo-workspaces to our repo for easier publishing. 
(I think we may need to do a dry run of this first to test)

fixes #2001
@jasonwilliams jasonwilliams deleted the cargoWorkspaces branch July 15, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raskad raskad raskad approved these changes

@Razican Razican Razican approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging this pull request may close these issues.

Use Cargo Workspaces for publishing
3 participants
@jasonwilliams @Razican @raskad