-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Using production builds for WebAssembly #1825
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit selects the production build (instead of development) for the WebAssembly compilation with Webpack, used in our playground. This might make things a bit faster and smaller. I also took the opportunity to update all the dependencies and the Test262 suite, but unfortunately this doesn't solve #1824.
Razican
added
performance
Performance related changes and issues
dependencies
Pull requests that update a dependency file
test
Issues and PRs related to the tests.
webassembly
Anything related to using Boa with WASM
labels
Feb 6, 2022
Razican
requested review from
jasonwilliams,
HalidOdat,
RageKnify,
raskad and
jedel1043
February 6, 2022 10:58
Test262 conformance changesVM implementation
|
Codecov Report
@@ Coverage Diff @@
## main #1825 +/- ##
=======================================
Coverage 55.73% 55.73%
=======================================
Files 201 201
Lines 17326 17326
=======================================
Hits 9656 9656
Misses 7670 7670 Continue to review full report at Codecov.
|
Benchmark for 7c61550Click to view benchmark
|
RageKnify
approved these changes
Feb 6, 2022
jedel1043
approved these changes
Feb 7, 2022
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 7, 2022
This commit selects the production build (instead of development) for the WebAssembly compilation with Webpack, used in our playground. This might make things a bit faster and smaller. I also took the opportunity to update all the dependencies and the Test262 suite, but unfortunately this doesn't solve #1824.
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Using production builds for WebAssembly
[Merged by Bors] - Using production builds for WebAssembly
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
enhancement
New feature or request
performance
Performance related changes and issues
test
Issues and PRs related to the tests.
webassembly
Anything related to using Boa with WASM
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit selects the production build (instead of development) for the WebAssembly compilation with Webpack, used in our playground. This might make things a bit faster and smaller.
I also took the opportunity to update all the dependencies and the Test262 suite, but unfortunately this doesn't solve #1824.