-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean-up contribution guidelines, dependencies, Test262, MSRV #1683
Conversation
This commit updates all dependencies in Rust and Yarn, also cleans-up the `test_ignore.txt` file a bit, where we had legacy comments. It uses the new flag in Cargo 1.56 to indicate that the minimum supported Rust version is, in fact, 1.56, which should help some compatibility diagnostics. It also updates the Test262 sub-module with the latest changes to the official test-suite. Finally, it adds a clarification in the contribution guidelines to make users of the Boa tester know that they can get more complete output by using the "very, very, verbose" output mode.
Test262 conformance changes:
Broken tests (14):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a bit concerned with the tests that stopped passing
Looked into the failing tests, think I know what's wrong, here's the code of one of them: var o1 = {
p: 'foo'
};
var result = Reflect.getOwnPropertyDescriptor(o1, 'p');
assert.compareArray(
Object.getOwnPropertyNames(result),
['value', 'writable', 'enumerable', 'configurable']
);
assert.sameValue(result.value, 'foo');
assert.sameValue(result.enumerable, true);
assert.sameValue(result.configurable, true);
assert.sameValue(result.writable, true); After some debugging the problem seems to be that Maybe a problem with how |
Yes this is definitely a scoping error. This issue describes the same error: #1663 |
Ok, I did think I'd seen it mentioned already, if we have an issue for it then I guess we can ignore the regression and let this PR through. |
Multiple small changes in this PR:
test_ignore.txt
file a bit, where we had legacy comments.