Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(boa): fixes Array.protoype.includes #1349

Merged
merged 6 commits into from
Jun 22, 2021

Conversation

neeldug
Copy link
Contributor

@neeldug neeldug commented Jun 19, 2021

This Pull Request fixes/closes #1306.

It changes the following:

  • adds fromIndex
  • adds infinity checking to indices

- adds fromIndex
- adds infinity checking to indices

Closes boa-dev#1306
@Razican
Copy link
Member

Razican commented Jun 20, 2021

Test262 conformance changes:

Test result master count PR count difference
Total 78,897 78,897 0
Passed 26,958 26,974 +16
Ignored 15,618 15,616 -2
Failed 36,321 36,307 -14
Panics 0 0 0
Conformance 34.17% 34.19% +0.02%
Fixed tests:
test/built-ins/Array/prototype/includes/length-boundaries.js [strict mode] (previously Ignored)
test/built-ins/Array/prototype/includes/length-boundaries.js (previously Ignored)
test/built-ins/Array/prototype/includes/return-abrupt-tointeger-fromindex.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/includes/return-abrupt-tointeger-fromindex.js (previously Failed)
test/built-ins/Array/prototype/includes/fromIndex-infinity.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/includes/fromIndex-infinity.js (previously Failed)
test/built-ins/Array/prototype/includes/fromIndex-equal-or-greater-length-returns-false.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/includes/fromIndex-equal-or-greater-length-returns-false.js (previously Failed)
test/built-ins/Array/prototype/includes/return-abrupt-tointeger-fromindex-symbol.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/includes/return-abrupt-tointeger-fromindex-symbol.js (previously Failed)
test/built-ins/Array/prototype/includes/tointeger-fromindex.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/includes/tointeger-fromindex.js (previously Failed)
test/built-ins/Array/prototype/includes/using-fromindex.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/includes/using-fromindex.js (previously Failed)
test/built-ins/Array/prototype/includes/sparse.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/includes/sparse.js (previously Failed)

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Copy link
Contributor

@RageKnify RageKnify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'd just like a comment to make sure the code is easy to understand.

boa/src/builtins/array/mod.rs Outdated Show resolved Hide resolved
@Razican Razican requested a review from RageKnify June 21, 2021 07:50
@Razican
Copy link
Member

Razican commented Jun 21, 2021

This just needs a rebase and we can merge it :)

@neeldug neeldug requested a review from Razican June 22, 2021 10:48
@Razican Razican added this to the v0.13.0 milestone Jun 22, 2021
@Razican Razican added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Jun 22, 2021
@Razican Razican merged commit 83ac2a9 into boa-dev:master Jun 22, 2021
@neeldug neeldug deleted the fix-array-protoype-includes branch June 22, 2021 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some Test262 tests run forever
3 participants