Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gc requirement from 0.3.6 to 0.4.0 in /boa #1134

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 17, 2021

Updates the requirements on gc to permit the latest version.

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @Razican.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Feb 17, 2021
@Razican
Copy link
Member

Razican commented Feb 17, 2021

@dependabot squash and merge

@Razican
Copy link
Member

Razican commented Feb 21, 2021

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Feb 21, 2021

Looks like this PR is already up-to-date with master! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@jasonwilliams
Copy link
Member

@Razican do we know what changes happened in 0.3.6 to 0.4.0 ?

@dependabot dependabot bot force-pushed the dependabot/cargo/boa/gc-0.4.0 branch 2 times, most recently from 4a4caca to 335aa31 Compare March 6, 2021 14:06
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 6, 2021

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@Razican
Copy link
Member

Razican commented Mar 6, 2021

@Razican do we know what changes happened in 0.3.6 to 0.4.0 ?

Not really, I was hoping it would be a transparent update, but we might need to review it further. I might have some free time tomorrow or on Monday.

@dependabot dependabot bot force-pushed the dependabot/cargo/boa/gc-0.4.0 branch from 335aa31 to c9170fa Compare March 6, 2021 14:54
@jasonwilliams
Copy link
Member

There's a breaking change between 0.3.6 to 0.4.0
image

Issue raised:
#1160

@Razican
Copy link
Member

Razican commented Mar 8, 2021

The breaking change came in Manishearth/rust-gc#123

@RageKnify
Copy link
Member

We can close this since the update will be handled by a PR addressing #1160, right?

@Razican
Copy link
Member

Razican commented Mar 10, 2021

Yep, let's close.

@Razican Razican closed this Mar 10, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 10, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/cargo/boa/gc-0.4.0 branch March 10, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants