Implement Set builtin object #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test262 conformance changes:
|
Codecov Report
@@ Coverage Diff @@
## master #1111 +/- ##
==========================================
+ Coverage 58.53% 58.80% +0.27%
==========================================
Files 176 179 +3
Lines 12547 12821 +274
==========================================
+ Hits 7344 7540 +196
- Misses 5203 5281 +78
Continue to review full report at Codecov.
|
Benchmark for df00d23Click to view benchmark
|
Benchmark for 5f30569Click to view benchmark
|
Benchmark for d18aa53Click to view benchmark
|
Benchmark for c12c36aClick to view benchmark
|
Benchmark for 75806b3Click to view benchmark
|
Benchmark for 93823cbClick to view benchmark
|
HalidOdat
reviewed
Feb 16, 2021
Benchmark for 209e32aClick to view benchmark
|
Benchmark for 5d4c262Click to view benchmark
|
HalidOdat
added
enhancement
- Fix Map.length - Fix msg for invoking Map without new - Simplify calculation of map size when displaying Maps
- Introduce IteratorClose - Fix a few errors in Set covered by test262 - Fix switch of PropertyDescriptor kind - Fix deletion of accessor properties (UnaryOp change) - Fix symbol equality
Co-Authored-By: HalidOdat <[email protected]>
RageKnify
added
enhancement
Benchmark for 7af5f9eClick to view benchmark
|
Benchmark for 3c6d330Click to view benchmark
|
Razican
approved these changes
May 10, 2021
Also make some minor changes to fulfill clippy lints
Benchmark for 77451b1Click to view benchmark
|
HalidOdat
approved these changes
May 11, 2021
|
The build failure is due to changes in |
Benchmark for f0a4b60Click to view benchmark
|
HalidOdat
reviewed
May 12, 2021
HalidOdat
reviewed
May 12, 2021
Speed up access to the prototype in the constructors Co-Authored-By: HalidOdat <[email protected]>
Benchmark for fb495bdClick to view benchmark
|
|
The MacOS CI "failure" was just a problem on GHs side, tests have been working so far, no reason to expect them to fail now. |
HalidOdat
approved these changes
May 19, 2021
Razican
pushed a commit
that referenced
this pull request
May 22, 2021
Co-authored-by: HalidOdat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #400.
Besides implementing
Setthis PR also changes the following:Value::hashso that1i32 == 1f64Map.prototype.length(was 1, should be 0 because the argument is optional)OrderedMaprather than going throught the propertyValue::SymbolThe change to
Value::hashwas a bandaid fix to the fact that incrementing/decrementing integers with++/--results in a float, that should still be addressed, but I think this change would still be needed.ps: I'll leave the remaining tests failing, currently failing tests [19] can be grouped by:
WeakSetto be implemented [14]Set.prototype.forEachwhen elements are removed (tracked in Deleting elements from a map during forEach results in invalid iteration #1092 forMap, solution will likely be easily translated toSet) [2]thisto beundefinedin strict mode [1]$262to be defined and use$262.createRealm()[2]tests that expect(tested locally, they pass now that Implement Reflect built-in object #1033 has been merged)Reflectto be implemented, which should pass once Implement Reflect built-in object #1033 is merged [2]