Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.8.278.1 #40

Merged
merged 3 commits into from
Jan 27, 2021
Merged

8.8.278.1 #40

merged 3 commits into from
Jan 27, 2021

Conversation

bnoordhuis
Copy link
Owner

No description provided.

@bnoordhuis bnoordhuis mentioned this pull request Nov 16, 2020
@gengjiawen
Copy link
Collaborator

gengjiawen commented Jan 20, 2021

The windows bug fixed in upstream. You can now do a update again.

@gengjiawen
Copy link
Collaborator

The windows bug fixed in upstream. You can now do a update again.

Related issue: https://bugs.chromium.org/p/v8/issues/detail?id=11241#c1.

@gengjiawen
Copy link
Collaborator

Looks like not cherrypicked to 8.8 yet v8/v8@deb0813.

Original commit message:

    [heap] Add proper rebind support to StrongRootBlockAllocator

    MSVC's STL in debug mode rebinds the allocator passed to vectors to
    allocate helper structures, so we need StrongRootBlockAllocator to
    have proper rebind support rather than assuming it always rebinds
    to Address.

Fixes MSVC debug builds.
@bnoordhuis bnoordhuis merged commit 29ce8bb into master Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants