Fix build on windows #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide a stub `third_party_heap::Heap` implementation to work around linker erors with Visual Studio. Refs: bnoordhuis#10
Run d:\a\v8-cmake/build/d8 -e 42
d:\a\v8-cmake/build/d8 -e 42
shell: C:\Program Files\PowerShell\7\pwsh.EXE -command ". '{0}'"
##[error]Process completed with exit code 1.windows never been easy :( |
bnoordhuis
reviewed
Apr 18, 2020
|
Wow, all checks passed. Great job! I need to properly squash the commits containing/touching the V8 patch and I don't have time for that right now but I'll try to get to it tonight. Thanks, Jiawen! |
|
Landed in d4eb596...4c13231, thanks again! |
bnoordhuis
pushed a commit
that referenced
this pull request
Apr 21, 2020
Fixes: #10 PR-URL: #18 Reviewed-By: Ben Noordhuis <[email protected]>
bnoordhuis
pushed a commit
that referenced
this pull request
Apr 21, 2020
Fixes: #10 PR-URL: #18 Reviewed-By: Ben Noordhuis <[email protected]>
Merged
bnoordhuis
pushed a commit
that referenced
this pull request
Apr 21, 2020
Fixes: #10 PR-URL: #18 Reviewed-By: Ben Noordhuis <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #3.
Fix #10