Skip to content

Commit

Permalink
build: disable SSLv2 by default
Browse files Browse the repository at this point in the history
No one in this day and age should be using SSLv2 so disable it by
default. You can re-enable it with `./configure --with-sslv2` but
there really should be no reason for that.
  • Loading branch information
bnoordhuis committed Aug 10, 2013
1 parent c937f5b commit 39aa894
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions configure
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,6 @@ parser.add_option('--no-ifaddrs',
dest='no_ifaddrs',
help='use on deprecated SunOS systems that do not support ifaddrs.h')

parser.add_option('--no-ssl2',
action='store_true',
dest='no_ssl2',
help='disable OpenSSL v2')

# deprecated
parser.add_option('--openssl-includes',
action='store',
Expand Down Expand Up @@ -230,6 +225,11 @@ parser.add_option('--with-perfctr',
dest='with_perfctr',
help='build with performance counters (default is true on Windows)')

parser.add_option('--with-sslv2',
action='store_true',
dest='with_sslv2',
help='enable SSL v2')

parser.add_option('--without-dtrace',
action='store_true',
dest='without_dtrace',
Expand Down Expand Up @@ -588,7 +588,9 @@ def configure_openssl(o):
if options.without_ssl:
return

if options.no_ssl2:
# OpenSSL uses `#ifndef OPENSSL_NO_SSL2` checks so only define the
# macro when we want to _disable_ SSL2.
if not options.with_sslv2:
o['defines'] += ['OPENSSL_NO_SSL2=1']

if options.shared_openssl:
Expand Down

0 comments on commit 39aa894

Please sign in to comment.