it leverages the recent addition of PR bndtools#5912 that allowed to add annotations in comments of files in META-INF/services. But in this PR we basically pretent and add a aQute.bnd.annotation.spi.ServiceProvider annotation artificially. this causes bnd to generate Provide-Capability manifest headers for the services

Signed-off-by: Christoph Rueger <[email protected]>

Signed-off-by: Christoph Rueger <[email protected]>

Signed-off-by: Christoph Rueger <[email protected]>

e.g. onmouseover in bnd.bnd editor shows help text.

Signed-off-by: Christoph Rueger <[email protected]>

From this all instructions would benefit

Signed-off-by: Christoph Rueger <[email protected]>

Signed-off-by: Christoph Rueger <[email protected]>

experimental: BndMavenPlugin set pendantic:true

Experimental: this causes more logging output which could be important during building bundles (but maybe not for baselining, so we only do it in BndMavenPlugin)

Signed-off-by: Christoph Rueger <[email protected]>

This reverts commit 96d6fdc.

Signed-off-by: Christoph Rueger <[email protected]>

This is a patch by and on behalf of @pkriens which fixes that a dependency to biz.aQute.bnd.annotation needs to be on the classpath. This simplifies wrapping bundles and use the new -metainf-services: auto instruction by not requiring additional bnd dependencies in the case where they are using the textual way of annotating metainf/services files with annotations in comments

Signed-off-by: Christoph Rueger <[email protected]>

- 'auto' as the new default makes things much easier for library authors since no additional configuration is required

Signed-off-by: Christoph Rueger <[email protected]>

This makes 'auto' the default again and fixes the previously failing tests.
The problem was that the "@Serviceprovider" from our own classpath added Java-17 (or whatever was the Java version on the machine you are compiling) to the list of ees which had an impact on how osgi.ee was calculated... this broke all the tests.
the fix was in Analyzer to ignore all classes added via addClasspathDefault() for calculation of the ees variable.

Signed-off-by: Christoph Rueger <[email protected]>

fix failing gradle tests

filter out invalid fqn names e.g. key=value

e.g. fixes [ERROR] [org.gradle.api.Task] error  : analyzer processing annotation key=value but the associated class is not found in the JAR

because key=value is not a valid serviceImplementation name

Signed-off-by: Christoph Rueger <[email protected]>

add resolution: optional to try to fix test

auto-registered annotations are added with "resolution: optional" directive, in order to fix tests which failed due to Unresolved requirements: osgi.extender; (&(osgi.extender=osgi.serviceloader.registrar)(version>=1.0.0)(!(version>=2.0.0))) which was added by the auto-registed annotations

Signed-off-by: Christoph Rueger <[email protected]>

addClasspathDefault() adds the annotation class to lookAsideClasses instead of classspace and adjust findClass() which now also looks into this new map. That way we don't not put stuff in classspace which should not be there

Signed-off-by: Christoph Rueger <[email protected]>

we rely on the error in Analyzer.findClass() if someone puts garbage in services files

Signed-off-by: Christoph Rueger <[email protected]>

we decided to make '-metainf-services: annotation the default. so '-metainf-services: auto' has to explicity be enabled in bnd file.
This decision was due to the fact that it is a brand new feature, and the impact on projects in the wild are hard to predict, since it changes metadata in MANIFEST.MF. So it is unclear at the moment if this would be considered a breaking change. So to be safe, we do not do 'auto' by default but 'annotation'. that means that textual annotations in META-INF/services files are automatically processed, because they were put there on purpose.

this commit also adjusts and adds some testcases based on that behavior.

Signed-off-by: Christoph Rueger <[email protected]>

Signed-off-by: Christoph Rueger <[email protected]>

fixes the little annoyance that some code blocks appeared cutoff on the right side

Signed-off-by: Christoph Rueger <[email protected]>

Signed-off-by: Christoph Rueger <[email protected]>

used by BndScanner
Signed-off-by: Christoph Rueger <[email protected]>