Workspace templates: remove old bndtools/workspace #6164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from initialrepos.txt, because in bndtools#5955 we kind of agreed to remove https://github.com/bndtools/workspace workspace template and just keep the bndtools/bndtools.workspace.min , because workspace templates will most likely be superseded by Template Fragments Signed-off-by: Christoph Rueger <[email protected]>
|
@pkriens @scottslewis if you know if any other places where the old workspace template is referenced let me know. |
|
I've no recollection so lets find out? :-) |
Signed-off-by: Christoph Rueger <[email protected]>
I've found two more references. I am on the road today, so feel free to merge, if you want. |
I interpret that as a "let's merge an find out". Since the change is minimal, it is easy to revert in case we notice something bad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5955
from initialrepos.txt, because in #5955 we kind of agreed to remove https://github.com/bndtools/workspace workspace template and just keep the bndtools/bndtools.workspace.min , because workspace templates will most likely be superseded by Template Fragments
After this the Create Workspace dialog looks like this for new users.