Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix windows build and add build-check job #162

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

j75689
Copy link
Collaborator

@j75689 j75689 commented Oct 9, 2024

Description

  1. fix widnwos binary build from ci
  2. add a ci job for binary build to check whether the binary file can be built normally.

Rationale

error[E0432]: unresolved import `net_if`
  --> crates/net/nat/src/lib.rs:17:9
   |
17 | pub use net_if::{NetInterfaceError, DEFAULT_NET_IF_NAME};
   |         ^^^^^^ use of undeclared crate or module `net_if`

warning: extern crate `if_addrs` is unused in crate `reth_net_nat`
   |
   = help: remove the dependency or add `use if_addrs as _;` to the crate root
note: the lint level is defined here
  --> crates/net/nat/src/lib.rs:12:29
   |
12 | #![cfg_attr(not(test), warn(unused_crate_dependencies))]
   |                             ^^^^^^^^^^^^^^^^^^^^^^^^^

   Compiling reth-ecies v1.0.5 (/project/crates/net/ecies)

Example

n/a

Changes

Notable changes:

  • no

Potential Impacts

  • no

@j75689 j75689 changed the title chore: fix windows build failed ci: fix windows build and add build-check job Oct 9, 2024
@unclezoro unclezoro merged commit 6abcab0 into bnb-chain:develop Oct 11, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants