fix(op-e2e): fallback to not use bsc specific method eth_getFinalizedBlock #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Block in e2e-test
owen-reorg
previously approved these changes
Oct 12, 2023
bendanzhentan
suggested changes
Oct 12, 2023
bendanzhentan
approved these changes
Oct 12, 2023
bendanzhentan
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix op-e2e test ci
Rationale
currently op-e2e use go-ethereum in memory as L1, so bsc specific rpc method eth_getFinalizedBlock is not supported
this pr fallback to not use eth_getFinalizedBlock if it's not supported
Example
Changes
L1Client fallback to not use eth_getFinalizedBlock if it's not supported