bugfix(op-node): fix the issue of inaccurate peerCount Metric #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
When we use DNS to specify the addresses of staticPeers, there may be a situation where one peer corresponds to multiple connections. Therefore, the same peer may trigger the
Connected
or theDisconnected
event ofNotifiee
multiple times. This will cause inaccurate peerCount statistics. In addition, restarting the op-node service may also cause statistical problems. Because peerCount is a gauge type indicator, if theDisconnected
event cannot be processed in time when the service is closed, peerCount may retain incorrect data and will not decrease to 0.Solution
In order to minimize the impact of duplicate events and server restarts, we should use
Gauge.Set(float64)
instead of the currently usedInc*()
andDec*()
methods. Getting the length of the peers array stored in theNetwork
object each time will make the statistical indicators more accurate.