feat: check channel timed out before data submission #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specification
Previously, Batcher would check the channel timeout after confirming a transaction.
Now this PR also checks the channel timeout before sending a transaction.
If there are pending channel frames that have not yet been submitted and the current l1Head exceeds the channel timeout, it is advisable to cancel the pending channel to prevent unnecessary submission.
By canceling the pending channel, its blocks will be re-pushed back to the pending blocks queue. And later, the Batcher will make attempt to construct a new channel.
Rational
Check channel timeout before sending transactions to reduce the probability of on-chain channel timeout.
Context for reproducing issue
wait(channel_timeout)
Review suggestion
This additional check is not required if we can guarantee sufficient balance
The probability is very low.
My personal opinion would be to close this PR.