fix: fix el bug #215
Merged
fix: fix el bug #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
welkin22
reviewed
Jul 8, 2024
owen-reorg
reviewed
Jul 10, 2024
owen-reorg
reviewed
Jul 10, 2024
owen-reorg
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When starting the op-node, if the gossip broadcast of the unsafe payload triggers before the pipeline reset, there will be issues with determining whether to enter engine-sync mode. Additionally, in the new version of the engine-sync process, if geth is unable to sync due to certain reasons (e.g., zero peers), the current logic in op-node will still update the unsafe height. This PR addresses these 2 issues.
Rationale
This update adds handling logic for cases where insertUnsafe executes earlier than the reset process. It also includes a fallback mechanism to retrieve unsafe from geth. Additionally, the op-node's unsafe height is now only updated after engine-sync is completed.
Example
N/A
Changes