Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devnet): batcher uses its address to submit transactions #211

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

welkin22
Copy link
Contributor

Description

Previously at Devnet, the batcher used the address of init holder for submission, causing unnecessary trouble. Now, we give the batcher its own address to avoid issues caused by sharing the same address with the init holder's users simultaneously.

Rationale

In devnet, the batcher uses its own address to avoid conflicts.

Example

none

Changes

Notable changes:

  • Add the batcher address to the l1env file.
  • Modify Devnet deployment script

owen-reorg
owen-reorg previously approved these changes Jun 18, 2024
Copy link
Contributor

@redhdx redhdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@welkin22 welkin22 merged commit 40cf16b into bnb-chain:develop Jun 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants