feat: op-batcher auto switch to economic DA type #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
welkin22
reviewed
Jun 13, 2024
welkin22
reviewed
Jun 13, 2024
krish-nr
reviewed
Jun 14, 2024
owen-reorg
reviewed
Jun 16, 2024
owen-reorg
approved these changes
Jun 20, 2024
owen-reorg
approved these changes
Jun 20, 2024
welkin22
reviewed
Jun 21, 2024
|
Note that this now got implemented upstream at ethereum-optimism/optimism#11219 @bnoieh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
new feature: op-batcher auto switch to economic DA type
Rationale
As blob gas price may increase to make blobTx more expensive than calldataTx, currently op-batcher could not choose economic DA type automatically, this PR filled the gap.
Example
n/a
Changes
autoto flag--data-availability-type, which will enable op-batcher automatically choose DA type--txmgr.blob-gas-price-limitfrom 100gwei to 0, which will disable blob-gas-price-limit by default.