-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(op-node): support multi clients to fetch blobs #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
welkin22
reviewed
May 15, 2024
welkin22
reviewed
May 15, 2024
andyzhang2023
previously approved these changes
May 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
owen-reorg
reviewed
May 28, 2024
owen-reorg
previously approved these changes
May 29, 2024
welkin22
approved these changes
May 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
andyzhang2023
approved these changes
May 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
--l1.archive-blob-rpc=archive_url_1,archive_url_2
to fallback to archive blob node when fetching blobs which non-archive blob nodes don't have--l1
; if set, op-node will create blob clients both from--l1
and--l1.archive-blob-rpc
, and will rotate all endpoints whenever a client runs into an error or return nil(skip non-archive node) while fetching blobs.Rationale
to support fallback to archive blob node when fetching blobs which non-archive blob nodes don't have
Example
n/a
Changes
BSCBlobClient
, which including a client pool to fetching blobs.l1.archive-blob-rpc
,l1.blob-rpc-rate-limit
,l1.blob-rpc-max-batch-size