feat: implement reconciliation onchain #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## develop #956 +/- ##
===========================================
- Coverage 49.46% 49.08% -0.39%
===========================================
Files 126 127 +1
Lines 12570 12698 +128
===========================================
+ Hits 6218 6233 +15
- Misses 5932 6042 +110
- Partials 420 423 +3
☔ View full report in Codecov by Sentry. |
forcodedancing
force-pushed
the
feat/sec_enhancement
branch
5 times, most recently
from
0eac8a5
to
d4c0cf0
Compare
yutianwu
reviewed
Jun 5, 2023
app/reconciliation.go
Outdated
| preCoins = preCoins.Plus(nacc2.GetLockedCoins()) | ||
| } | ||
| } | ||
| iavlStore.ResetDiff() |
There was a problem hiding this comment.
can we reset diff outside this function, it would be better this function is just a view function.
There was a problem hiding this comment.
refactored the codes
forcodedancing
force-pushed
the
feat/sec_enhancement
branch
from
1b2b4c3
to
42aad21
Compare
unclezoro
reviewed
Jun 25, 2023
unclezoro
reviewed
Jun 25, 2023
unclezoro
approved these changes
Jun 27, 2023
forcodedancing
force-pushed
the
feat/sec_enhancement
branch
from
a874af1
to
8cfb1f0
Compare
revert some changes
forcodedancing
force-pushed
the
feat/sec_enhancement
branch
from
45a76da
to
d85e3fc
Compare
|
State Sync can work. |
forcodedancing
added a commit
to forcodedancing/node
that referenced
this pull request
Jul 7, 2023
forcodedancing
added a commit
to forcodedancing/node
that referenced
this pull request
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr will
Rationale
Security Enhancement
Example
NA
Changes
Notable changes:
Preflight checks
make build)make test)make integration_test)Already reviewed by
...
Related issues
... reference related issue #'s here ...