Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R4R]fix the dockerfile and add ci script to docker image #878

Merged
merged 2 commits into from
Jul 15, 2022

Conversation

j75689
Copy link
Contributor

@j75689 j75689 commented Jul 15, 2022

Description

  1. Automatically upload the latest version of Docker Image to GitHub package when a new version is released
  2. Fix dockerfile to make sure images work

Rationale

N/A

Example

docker run -p 27146:27146 -p 27147:27147 -e NETWORK=testnet ghcr.io/bnb-chain/node:latest

Changes

N/A

Preflight checks

  • build passed (make build)
  • tests passed (make test)
  • integration tests passed (make integration_test)
  • manual transaction test passed (cli invoke)

Already reviewed by

N/A

Related issues

N/A

[R4R] prepare for release v0.10.0
@j75689 j75689 changed the title feat: add ci script to docker image [R4R]fix the dockerfile and add ci script to docker image Jul 15, 2022
@forcodedancing
Copy link
Contributor

Can we firstly pull-request the changes to develop branch firstly?

@j75689 j75689 changed the base branch from master to develop July 15, 2022 07:31
@j75689
Copy link
Contributor Author

j75689 commented Jul 15, 2022

Can we firstly pull-request the changes to develop branch firstly?

sure, changed

@unclezoro unclezoro merged commit e47afdc into bnb-chain:develop Jul 15, 2022
@unclezoro unclezoro mentioned this pull request Aug 17, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants