Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R4R] add lint workflow #858

Merged
merged 47 commits into from
Apr 25, 2022
Merged

[R4R] add lint workflow #858

merged 47 commits into from
Apr 25, 2022

Conversation

owen-reorg
Copy link
Contributor

@owen-reorg owen-reorg commented Apr 24, 2022 •
edited
Loading

Description

Add lint workflow to lint for every pull request and commit.

Rationale

Help improve code quality and prevent hidden bugs.

Example

CleanShot 2022-04-25 at 10 13 23@2x

Changes

Preflight checks

  • build passed (make build)
  • tests passed (make test)
  • integration tests passed (make integration_test)
  • manual transaction test passed (cli invoke)

Already reviewed by

...

Related issues

... reference related issue #'s here ...

@owen-reorg
chore: add integration test workflow
9d118dc
@owen-reorg
add build and test in workflow
b8b5dcd
@owen-reorg
optimize workflow cache
39855d1
@owen-reorg
skip error file
bca49ef
@owen-reorg
Merge branch 'develop' of github-nodereal:bnb-chain/node into github-…
e583725 
…workflow
@owen-reorg
feat: add release workflow
411275a
@owen-reorg
fix release workflow
e8dc66e
@owen-reorg
disable window to debug
7e06abe
@owen-reorg
test release name
4f8cd2a
@owen-reorg
fix release tag
ffa73b1
@owen-reorg
fix release tag
a759bda
@owen-reorg
add macos
7294c0c
@owen-reorg
fix macos
5e6f02f
@owen-reorg
fix make test
efa5369
@owen-reorg
remove windows, zip before upload
70b8eee
@owen-reorg
remove build in integration ci
a0d9c2b
@owen-reorg
update integration
7262ff3
@owen-reorg
update release
7cca184
@owen-reorg
fix integration test
7fb3a69
@owen-reorg
debug
9b2b1f8
@owen-reorg
remove debug
2648a48
@owen-reorg
clean up
b6169ea
@owen-reorg
adjust release strategy
aa35d7d
@owen-reorg
fix multiple cmds
179b4dc
@owen-reorg
fix paramhub
e452715
@owen-reorg
get app_pub back
44538ac
@owen-reorg
remove app_pub_test
ab08981
@owen-reorg
add lint
821b28a
@owen-reorg
fix lint
c947068
@owen-reorg
fix pub
b332095
@owen-reorg owen-reorg changed the base branch from master to develop April 24, 2022 07:18
forcodedancing
forcodedancing approved these changes Apr 25, 2022
View reviewed changes
plugins/dex/matcheng/engine.go Outdated Show resolved Hide resolved
plugins/dex/order/keeper_recovery.go Show resolved Hide resolved
plugins/dex/order/keeper_recovery.go Show resolved Hide resolved
plugins/dex/matcheng/engine.go Outdated Show resolved Hide resolved
@forcodedancing forcodedancing changed the title chore: add lint workflow [R4R] add lint workflow Apr 25, 2022
@forcodedancing forcodedancing merged commit e19ddde into bnb-chain:develop Apr 25, 2022
@forcodedancing forcodedancing mentioned this pull request Apr 28, 2022
Merged
forcodedancing pushed a commit that referenced this pull request May 19, 2022
@owen-reorg @forcodedancing
[R4R] add lint workflow (#858)
3bc9da4
forcodedancing pushed a commit that referenced this pull request May 19, 2022
@owen-reorg @forcodedancing
[R4R] add lint workflow (#858)
966ba02
forcodedancing pushed a commit that referenced this pull request May 19, 2022
@owen-reorg @forcodedancing
[R4R] add lint workflow (#858)
abe9b63
forcodedancing pushed a commit that referenced this pull request May 19, 2022
@owen-reorg @forcodedancing
[R4R] add lint workflow (#858)
74557b4
forcodedancing pushed a commit that referenced this pull request May 19, 2022
@owen-reorg @forcodedancing
[R4R] add lint workflow (#858)
c186cbb
forcodedancing pushed a commit that referenced this pull request May 19, 2022
@owen-reorg @forcodedancing
[R4R] add lint workflow (#858)
1f529b8
forcodedancing pushed a commit that referenced this pull request May 19, 2022
@owen-reorg @forcodedancing
[R4R] add lint workflow (#858)
805d323
forcodedancing pushed a commit that referenced this pull request May 19, 2022
@owen-reorg @forcodedancing
[R4R] add lint workflow (#858)
b72e799
forcodedancing pushed a commit that referenced this pull request May 19, 2022
@owen-reorg @forcodedancing
[R4R] add lint workflow (#858)
7152a85
forcodedancing pushed a commit that referenced this pull request May 19, 2022
@owen-reorg @forcodedancing
[R4R] add lint workflow (#858)
04470d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forcodedancing forcodedancing forcodedancing approved these changes

@unclezoro unclezoro unclezoro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@owen-reorg @unclezoro @forcodedancing