R4R: Implement BEP84 #809
Merged
R4R: Implement BEP84 #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelliumnt
force-pushed
the
bep100
branch
5 times, most recently
from
8385ee7
to
eaa2cb5
Compare
unclezoro
reviewed
Dec 28, 2020
unclezoro
reviewed
Dec 28, 2020
unclezoro
reviewed
Dec 28, 2020
| // TODO: distribute fee | ||
|
|
||
| return sdk.ExecuteResult{ | ||
| Payload: ackPackage, |
There was a problem hiding this comment.
We need more tags here to indicate what happend in this oracle claim. We have many oracle claims for one cross chain package, need to know which one take effect and what happens inside.
unclezoro
reviewed
Dec 28, 2020
plugins/bridge/cross_app.go
Outdated
|
|
||
| // TODO: distribute fee | ||
|
|
||
| return sdk.ExecuteResult{} |
There was a problem hiding this comment.
No ACK package return here, I guess BSC is expecting aj ack package when sync success.
abelliumnt
force-pushed
the
bep100
branch
3 times, most recently
from
d7392b4
to
0736700
Compare
update cosmos dependency
register channel
update token supply
unclezoro
reviewed
Jan 4, 2021
| func (app *MirrorApp) checkMirrorSynPackage(ctx sdk.Context, mirrorPackage *types.MirrorSynPackage) uint8 { | ||
| // check expire time | ||
| if ctx.BlockHeader().Time.Unix() > int64(mirrorPackage.ExpireTime) { | ||
| return types.MirrorErrCodeExpired |
There was a problem hiding this comment.
MirrorErrCodeExpired is not proper here.
There was a problem hiding this comment.
Sorry I mean MirrorErrCodeUnknown
unclezoro
reviewed
Jan 4, 2021
plugins/bridge/cross_app.go
Outdated
| symbol := types.BytesToSymbol(mirrorPackage.BEP20Symbol) | ||
| err := ctypes.ValidateIssueSymbol(symbol) | ||
| if err != nil { | ||
| return types.MirrorErrCodeUnknown |
There was a problem hiding this comment.
Just check all the place that use MirrorErrCodeUnknown .
unclezoro
reviewed
Jan 4, 2021
unclezoro
approved these changes
Jan 5, 2021
EnderCrypto
reviewed
Jan 11, 2021
| "type": "array", | ||
| "items": { | ||
| "type": "record", | ||
| "name": "Mirror", |
There was a problem hiding this comment.
Can't redefine: org.binance.dex.explorer.work.domain.avro.mirror.Mirror , the name is duplicate to line 895
Can you change it to "MirrorData"?
abelliumnt
approved these changes
Jan 15, 2021
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* implement bep100 update cosmos dependency * add upgrade height for FixFailAckPackage register channel * convert to bep20 supply in sync update token supply * distribute fee * the mirror and sync fee in package is already converted into BC amount * update dependency * enable account scripts for cross chain transfer * register upgrade height * send only no script execution error * include refund package into result * add transfer in tag * use idx other than address as refund exclude flag * use full refund instead of partial refund * publish mirror related events (#813) * update mirror config * move deduct fee from deliverTx * fix comments * add missing tags * fix transfer out fail ack handler issue * update schmema * update dependency * add old total supply for mirror sync event * fix mirror event Co-authored-by: HaoyangLiu <[email protected]>
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* implement bep100 update cosmos dependency * add upgrade height for FixFailAckPackage register channel * convert to bep20 supply in sync update token supply * distribute fee * the mirror and sync fee in package is already converted into BC amount * update dependency * enable account scripts for cross chain transfer * register upgrade height * send only no script execution error * include refund package into result * add transfer in tag * use idx other than address as refund exclude flag * use full refund instead of partial refund * publish mirror related events (#813) * update mirror config * move deduct fee from deliverTx * fix comments * add missing tags * fix transfer out fail ack handler issue * update schmema * update dependency * add old total supply for mirror sync event * fix mirror event Co-authored-by: HaoyangLiu <[email protected]>
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* implement bep100 update cosmos dependency * add upgrade height for FixFailAckPackage register channel * convert to bep20 supply in sync update token supply * distribute fee * the mirror and sync fee in package is already converted into BC amount * update dependency * enable account scripts for cross chain transfer * register upgrade height * send only no script execution error * include refund package into result * add transfer in tag * use idx other than address as refund exclude flag * use full refund instead of partial refund * publish mirror related events (#813) * update mirror config * move deduct fee from deliverTx * fix comments * add missing tags * fix transfer out fail ack handler issue * update schmema * update dependency * add old total supply for mirror sync event * fix mirror event Co-authored-by: HaoyangLiu <[email protected]>
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* implement bep100 update cosmos dependency * add upgrade height for FixFailAckPackage register channel * convert to bep20 supply in sync update token supply * distribute fee * the mirror and sync fee in package is already converted into BC amount * update dependency * enable account scripts for cross chain transfer * register upgrade height * send only no script execution error * include refund package into result * add transfer in tag * use idx other than address as refund exclude flag * use full refund instead of partial refund * publish mirror related events (#813) * update mirror config * move deduct fee from deliverTx * fix comments * add missing tags * fix transfer out fail ack handler issue * update schmema * update dependency * add old total supply for mirror sync event * fix mirror event Co-authored-by: HaoyangLiu <[email protected]>
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* implement bep100 update cosmos dependency * add upgrade height for FixFailAckPackage register channel * convert to bep20 supply in sync update token supply * distribute fee * the mirror and sync fee in package is already converted into BC amount * update dependency * enable account scripts for cross chain transfer * register upgrade height * send only no script execution error * include refund package into result * add transfer in tag * use idx other than address as refund exclude flag * use full refund instead of partial refund * publish mirror related events (#813) * update mirror config * move deduct fee from deliverTx * fix comments * add missing tags * fix transfer out fail ack handler issue * update schmema * update dependency * add old total supply for mirror sync event * fix mirror event Co-authored-by: HaoyangLiu <[email protected]>
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* implement bep100 update cosmos dependency * add upgrade height for FixFailAckPackage register channel * convert to bep20 supply in sync update token supply * distribute fee * the mirror and sync fee in package is already converted into BC amount * update dependency * enable account scripts for cross chain transfer * register upgrade height * send only no script execution error * include refund package into result * add transfer in tag * use idx other than address as refund exclude flag * use full refund instead of partial refund * publish mirror related events (#813) * update mirror config * move deduct fee from deliverTx * fix comments * add missing tags * fix transfer out fail ack handler issue * update schmema * update dependency * add old total supply for mirror sync event * fix mirror event Co-authored-by: HaoyangLiu <[email protected]>
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* implement bep100 update cosmos dependency * add upgrade height for FixFailAckPackage register channel * convert to bep20 supply in sync update token supply * distribute fee * the mirror and sync fee in package is already converted into BC amount * update dependency * enable account scripts for cross chain transfer * register upgrade height * send only no script execution error * include refund package into result * add transfer in tag * use idx other than address as refund exclude flag * use full refund instead of partial refund * publish mirror related events (#813) * update mirror config * move deduct fee from deliverTx * fix comments * add missing tags * fix transfer out fail ack handler issue * update schmema * update dependency * add old total supply for mirror sync event * fix mirror event Co-authored-by: HaoyangLiu <[email protected]>
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* implement bep100 update cosmos dependency * add upgrade height for FixFailAckPackage register channel * convert to bep20 supply in sync update token supply * distribute fee * the mirror and sync fee in package is already converted into BC amount * update dependency * enable account scripts for cross chain transfer * register upgrade height * send only no script execution error * include refund package into result * add transfer in tag * use idx other than address as refund exclude flag * use full refund instead of partial refund * publish mirror related events (#813) * update mirror config * move deduct fee from deliverTx * fix comments * add missing tags * fix transfer out fail ack handler issue * update schmema * update dependency * add old total supply for mirror sync event * fix mirror event Co-authored-by: HaoyangLiu <[email protected]>
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* implement bep100 update cosmos dependency * add upgrade height for FixFailAckPackage register channel * convert to bep20 supply in sync update token supply * distribute fee * the mirror and sync fee in package is already converted into BC amount * update dependency * enable account scripts for cross chain transfer * register upgrade height * send only no script execution error * include refund package into result * add transfer in tag * use idx other than address as refund exclude flag * use full refund instead of partial refund * publish mirror related events (#813) * update mirror config * move deduct fee from deliverTx * fix comments * add missing tags * fix transfer out fail ack handler issue * update schmema * update dependency * add old total supply for mirror sync event * fix mirror event Co-authored-by: HaoyangLiu <[email protected]>
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* implement bep100 update cosmos dependency * add upgrade height for FixFailAckPackage register channel * convert to bep20 supply in sync update token supply * distribute fee * the mirror and sync fee in package is already converted into BC amount * update dependency * enable account scripts for cross chain transfer * register upgrade height * send only no script execution error * include refund package into result * add transfer in tag * use idx other than address as refund exclude flag * use full refund instead of partial refund * publish mirror related events (#813) * update mirror config * move deduct fee from deliverTx * fix comments * add missing tags * fix transfer out fail ack handler issue * update schmema * update dependency * add old total supply for mirror sync event * fix mirror event Co-authored-by: HaoyangLiu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add a description of your changes here...
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes:
Preflight checks
make build)make test)make integration_test)Already reviewed by
...
Related issues
... reference related issue #'s here ...