remove orderInfo from orderInfoForPub when publish anything #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ackratos
previously approved these changes
Jul 13, 2020
|
Sorry dude:( |
EnderCrypto
force-pushed
the
release/0.7.2-hotfix
branch
from
60ce3f2
to
6e58b01
Compare
fletcher142
previously approved these changes
Jul 13, 2020
EnderCrypto
changed the title
EnderCrypto
changed the title
added 2 commits
July 14, 2020 15:50
fletcher142
approved these changes
Jul 14, 2020
forcodedancing
approved these changes
Jul 14, 2020
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* add closed orders to ToRemoveOrderIdCh when ShouldPublishAny=true
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* add closed orders to ToRemoveOrderIdCh when ShouldPublishAny=true
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* add closed orders to ToRemoveOrderIdCh when ShouldPublishAny=true
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* add closed orders to ToRemoveOrderIdCh when ShouldPublishAny=true
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* add closed orders to ToRemoveOrderIdCh when ShouldPublishAny=true
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* add closed orders to ToRemoveOrderIdCh when ShouldPublishAny=true
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* add closed orders to ToRemoveOrderIdCh when ShouldPublishAny=true
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* add closed orders to ToRemoveOrderIdCh when ShouldPublishAny=true
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* add closed orders to ToRemoveOrderIdCh when ShouldPublishAny=true
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* add closed orders to ToRemoveOrderIdCh when ShouldPublishAny=true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Witness-explorer is lagging due to much longer Publish time. The root cause is OrderInfosForPub is not cleared after order closed for the node shouldPublishAny==true but publishOrderUpdates||publishOrderbook==false
Rationale
Remove order from OrderInfosForPub when shouldPublishAny==true
Example
add an example CLI or API response...
Changes
Notable changes:
Preflight checks
make build)make test)make integration_test)Already reviewed by
...
Related issues
... reference related issue #'s here ...