[R4R] tools: state_recover add index height rollback #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclezoro
changed the title
unclezoro
changed the title
unclezoro
changed the title
unclezoro
requested review from
rickyyangz,
ackratos and
abelliumnt
and removed request for
rickyyangz and
ackratos
unclezoro
commented
Sep 6, 2019
| @@ -37,7 +37,7 @@ | |||
| [[override]] | |||
| name = "github.com/tendermint/tendermint" | |||
| source = "github.com/binance-chain/bnc-tendermint" | |||
| version = "=v0.31.5-binance.0" | |||
There was a problem hiding this comment.
The master branch is =v0.31.5-binance.1, we don't omit =v0.31.5-binance.1, it is ok
unclezoro
force-pushed
the
resetindex
branch
from
0a4ba6a
to
b52ae1d
Compare
ackratos
approved these changes
Sep 6, 2019
rickyyangz
approved these changes
Sep 9, 2019
abelliumnt
approved these changes
Sep 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
resolve #issue bnb-chain/bnc-tendermint#105
there is new key in state db, refer to bnb-chain/bnc-tendermint#106
state_recover should reset the indexHeightKey.
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes:
Preflight checks
make build)make test)make integration_test)Already reviewed by
...
Related issues
... reference related issue #'s here ...