R4R: publish trade status #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darren-liu
requested changes
Jun 11, 2019
rickyyangz
force-pushed
the
match_revision
branch
3 times, most recently
from
afb6c57
to
dd03551
Compare
abelliumnt
force-pushed
the
publish-trade-status
branch
from
830540d
to
5187962
Compare
ackratos
approved these changes
Jun 18, 2019
added 2 commits
June 18, 2019 11:53
rickyyangz
approved these changes
Jun 18, 2019
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* Merge with match-revision branch * Change variable name
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* Merge with match-revision branch * Change variable name
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* Merge with match-revision branch * Change variable name
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* Merge with match-revision branch * Change variable name
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* Merge with match-revision branch * Change variable name
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* Merge with match-revision branch * Change variable name
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* Merge with match-revision branch * Change variable name
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* Merge with match-revision branch * Change variable name
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* Merge with match-revision branch * Change variable name
forcodedancing
pushed a commit
that referenced
this pull request
May 19, 2022
* Merge with match-revision branch * Change variable name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Publish trade status to kafka. Valid trade status can be:
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes:
Preflight checks
make build)make test)make integration_test)Already reviewed by
...
Related issues
... reference related issue #'s here ...