Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R4R]Field: price of TradingPair change to list_price #498

Merged
merged 1 commit into from
Mar 25, 2019
Merged

Conversation

unclezoro
Copy link
Collaborator

@unclezoro unclezoro commented Mar 14, 2019

Description

list_price is more meaningful.

Rationale

no

Example

add an example CLI or API response...

Changes

Notable changes:
This may affect downstream service.
@ackratos @xzjcool @erhenglu @jiangkai-rq please note.

Preflight checks

  • build passed (make build)
  • tests passed (make test)
  • integration tests passed (make integration_test)
  • manual transaction test passed (cli invoke)

Already reviewed by

...

Related issues

... reference related issue #'s here ...

@unclezoro unclezoro changed the title Field: price of TradingPair change to list_price [R4R]Field: price of TradingPair change to list_price Mar 14, 2019
@unclezoro unclezoro self-assigned this Mar 14, 2019
@unclezoro unclezoro requested review from darren-liu, rickyyangz, yutianwu and ackratos and removed request for darren-liu, rickyyangz and yutianwu March 14, 2019 11:31
Copy link
Contributor

@darren-liu darren-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really need to confirm with the downstream about when to merge and release.

@rickyyangz
Copy link
Contributor

rickyyangz commented Mar 15, 2019

incompatible change! Need to test and confirm whether we need fork logic.

@unclezoro
Copy link
Collaborator Author

incompatible change! Need to confirm when to merge, or use the fork logic...

I will give it a test

@unclezoro
Copy link
Collaborator Author

incompatible change! Need to test and confirm whether we need fork logic.

I did a test, amino marshall do not concern with the field name. After upgrade, the already exist markets are still readable. One thing should notice is that we need update bnbcli too.

@rickyyangz
Copy link
Contributor

incompatible change! Need to test and confirm whether we need fork logic.

I did a test, amino marshall do not concern with the field name. After upgrade, the already exist markets are still readable. One thing should notice is that we need update bnbcli too.

Great!

@unclezoro unclezoro merged commit 33a8855 into develop Mar 25, 2019
@unclezoro unclezoro deleted the listprice branch May 10, 2022 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants