Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R4R] #357 recover recent price on state sync #479

Merged
merged 1 commit into from
Mar 6, 2019
Merged

[R4R] #357 recover recent price on state sync #479

merged 1 commit into from
Mar 6, 2019

Conversation

ackratos
Copy link
Contributor

@ackratos ackratos commented Mar 6, 2019 •
edited
Loading

Description

recover recent price to make sure tick and lot size calculation is consistent after state sync

Rationale

missed tick/lot size change in state sync implementation (two separate work merge together)

Example

N/A

Changes

Preflight checks

  • build passed (make build)
  • tests passed (make test)
  • integration tests passed (make integration_test)
  • manual transaction test passed (cli invoke)

Already reviewed by

...

Related issues

#357

@ackratos ackratos added the bug Something isn't working label Mar 6, 2019
@ackratos ackratos self-assigned this Mar 6, 2019
@ackratos ackratos changed the title #357 recover recent price on state sync [R4R] #357 recover recent price on state sync Mar 6, 2019
@ackratos ackratos merged commit 8bc0da5 into develop Mar 6, 2019
@rickyyangz rickyyangz mentioned this pull request Mar 9, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickyyangz rickyyangz rickyyangz approved these changes

@darren-liu darren-liu darren-liu approved these changes

Assignees

@ackratos ackratos

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ackratos @darren-liu @rickyyangz