feat: add bls verification #239
Conversation
github-actions
bot
added
C:x/genutil
C:Simulations
C:x/slashing
C:x/staking
C:Keys
C:CLI
labels
j75689
changed the title
x/staking/keeper/msg_server.go
Outdated
| @@ -628,3 +656,23 @@ func (ms msgServer) UpdateParams(goCtx context.Context, msg *types.MsgUpdatePara | |||
|
|
|||
| return &types.MsgUpdateParamsResponse{}, nil | |||
| } | |||
|
|
|||
| // CheckBlsProof checks the BLS signature of the validator | |||
| func (ms msgServer) CheckBlsProof(goCtx context.Context, blsPk, sig []byte, valAddr sdk.Address) (bool, error) { | |||
There was a problem hiding this comment.
why not return error only, error means failed to verify.
There was a problem hiding this comment.
goctx and valAddr is useless.
| // SignMsgKeysCmd returns the Cobra Command for signing messages with the private key of a given name. | ||
| func SignMsgKeysCmd() *cobra.Command { | ||
| cmd := &cobra.Command{ | ||
| Use: "sign [message]", |
There was a problem hiding this comment.
This is a dangerous action, please note user to take care.
And give an example, it can be used to do possesion of proof..
| @@ -93,6 +93,10 @@ func (pubKey *PubKey) VerifySignature(msg, sig []byte) bool { | |||
| sig = sig[:len(sig)-1] | |||
| } | |||
|
|
|||
| if len(msg) != crypto.DigestLength { | |||
There was a problem hiding this comment.
why we add this? I did not expect any changes of ethsecp256k1.
There was a problem hiding this comment.
This is because the ethsecp256k1 Sign method allows the user to pass the message in 32bytes and does not force the message to be hashed.
However, hashing of the message is enforced when verifying the signature.
The logic on both sides is inconsistent.
There was a problem hiding this comment.
Anyways, I would remove these changes first to avoid causing other errors.
Description
add signature verification for
BLSkey when creating, editing the validator.Rationale
add a
Proof of Possessionto ensure the validator holds theBLSkey.Example
add an example CLI or API response...
Changes
Notable changes: