fix: security report fix #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:CLI
C:Simulations
C:x/authz
C:x/feegrant
C:x/group
C:x/nft
C:x/staking
labels
unclezoro
reviewed
May 22, 2023
types/cross_chain.go
Outdated
| @@ -94,6 +94,9 @@ func EncodePackageHeader(header PackageHeader) []byte { | |||
| copy(packageHeader[PackageTypeLength:PackageTypeLength+TimestampLength], timestampBytes) | |||
|
|
|||
| relayerFeeLength := len(header.RelayerFee.Bytes()) | |||
| if relayerFeeLength > 32 { | |||
There was a problem hiding this comment.
Please remove this.
It is ok if PackageHeader is wrong, as the protocol will handle this.
unclezoro
reviewed
May 22, 2023
x/authz/migrations/v2/keys.go
Outdated
| @@ -61,12 +61,13 @@ func ParseGrantKey(key []byte) (granterAddr, granteeAddr sdk.AccAddress, msgType | |||
| // key is of format: | |||
| // <granterAddressLen (1 Byte)><granterAddress_Bytes><granteeAddressLen (1 Byte)><granteeAddress_Bytes><msgType_Bytes> | |||
| kv.AssertKeyAtLeastLength(key, 2) | |||
| granterAddrLen := key[0] | |||
| // prevent granterAddrLen overflow | |||
There was a problem hiding this comment.
Please dont change this, as we did not use this, let us keep consistent with cosmos-sdk.
unclezoro
reviewed
May 22, 2023
x/group/internal/orm/key_codec.go
Outdated
| @@ -82,6 +82,9 @@ func stripRowID(indexKey []byte, secondaryIndexKey interface{}) (RowID, error) { | |||
| switch v := secondaryIndexKey.(type) { | |||
| case []byte: | |||
| searchableKeyLen := indexKey[0] | |||
| if 1+int(searchableKeyLen) > len(indexKey) { | |||
There was a problem hiding this comment.
Please dont change this as we dont use it.
unclezoro
reviewed
May 22, 2023
x/staking/migrations/v1/types.go
Outdated
| @@ -219,12 +219,22 @@ func ParseValidatorQueueKey(bz []byte) (time.Time, int64, error) { | |||
| return time.Time{}, 0, fmt.Errorf("invalid prefix; expected: %X, got: %X", ValidatorQueueKey, prefix) | |||
| } | |||
|
|
|||
| if prefixL+8 > len(bz) { | |||
| return time.Time{}, 0, fmt.Errorf("timeBzl is out of bounds") | |||
There was a problem hiding this comment.
We dont use this, so no need to change it.
unclezoro
reviewed
May 22, 2023
x/staking/types/keys.go
Outdated
| @@ -221,11 +221,18 @@ func ParseValidatorQueueKey(bz []byte) (time.Time, int64, error) { | |||
| } | |||
|
|
|||
| timeBzL := sdk.BigEndianToUint64(bz[prefixL : prefixL+8]) | |||
| if prefixL+8+int(timeBzL) > len(bz) { | |||
| return time.Time{}, 0, fmt.Errorf("ts is out of bounds") | |||
unclezoro
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
implemented changes according to the feedback in the security report
Rationale
issues such as overflow errors were raised
Example
none
Changes
please refer to the security report and the changed files