fix: data race issue #135
Merged
fix: data race issue #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pythonberg1997
force-pushed
the
wallet_support
branch
from
6b68e49
to
083dc3f
Compare
unclezoro
reviewed
Mar 16, 2023
x/auth/tx/eip712.go
Outdated
| @@ -180,11 +180,12 @@ func WrapTxToTypedData( | |||
| // filling nil value | |||
| cleanTypesAndMsgValue(msgTypes, "Msg", txData["msg"].(map[string]interface{})) | |||
|
|
|||
| domain.ChainId = math.NewHexOrDecimal256(int64(chainID)) | |||
| domainTemp := domain | |||
There was a problem hiding this comment.
It can not fix the race issue.
unclezoro
approved these changes
Mar 16, 2023
This was referenced Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr aims to fix data race issue within EIP712 sign mode's
GetSignBytesmethodRationale
The previous implementation is not thread-safe.
Changes
MsgCodec