use bls instead of blst to fix opBNB bls cgo issue #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
opBNB supported the pre-complied contract of greenfield at bnb-chain/op-geth#7, but the greenfield cometbft code introduced by this PR will prevent the compilation of the MIPS instruction set. It is necessary to solve this problem to support MIPS instruction set compilation in order to support Fault Proof.
Rationale
In fact, using bls instead of blst will give me the opportunity to compile the MIPS instruction set using a pure Go implementation instead of the CGO implementation inside blst. So I replaced the corresponding places with using bls. bls will call the same-named method in blst, so they are equivalent.
Example
none
Changes
Notable changes: