-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: trieJournal format compatible old db format #2395
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
can we avoid to change the interface of function loadDiffLayer, loadDiskLayer and journal? |
why a field |
We can avoid changing the interface of functions loadDiffLayer and loadDiskLayer. However, the journal is called by diffLayer and diskLayer, which cannot access db.config.JournalFilePath. |
Description
If trieJournal is stored in the database, it retains the old journal format; if trieJournal writes to the journal file using the new journal format;
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: