feat: greedy merge tx in bid #2363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclezoro
reviewed
Apr 7, 2024
unclezoro
reviewed
Apr 7, 2024
unclezoro
reviewed
Apr 7, 2024
unclezoro
reviewed
Apr 7, 2024
irrun
force-pushed
the
re/mevfix
branch
7 times, most recently
from
e80bc31
to
60e32b4
Compare
unclezoro
reviewed
Apr 7, 2024
unclezoro
reviewed
Apr 7, 2024
unclezoro
reviewed
Apr 7, 2024
unclezoro
reviewed
Apr 7, 2024
unclezoro
reviewed
Apr 7, 2024
unclezoro
reviewed
Apr 7, 2024
unclezoro
reviewed
Apr 7, 2024
unclezoro
reviewed
Apr 7, 2024
unclezoro
reviewed
Apr 7, 2024
unclezoro
reviewed
Apr 7, 2024
unclezoro
reviewed
Apr 8, 2024
unclezoro
reviewed
Apr 8, 2024
irrun
changed the title
unclezoro
reviewed
Apr 9, 2024
unclezoro
reviewed
Apr 9, 2024
unclezoro
previously approved these changes
Apr 9, 2024
zzzckck
reviewed
Apr 11, 2024
miner/worker.go
Outdated
| @@ -1080,6 +1081,29 @@ func (w *worker) fillTransactions(interruptCh chan int32, env *environment, stop | |||
| localBlobTxs[account] = txs | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
how about move it to line#1068, so only need to filter: pendingPlainTxs & pendingBlobTxs, could be more efficient.
| stopTimer := time.NewTimer(*delay) | ||
|
|
||
| bidTxsSet := mapset.NewSet[common.Hash]() | ||
| for _, tx := range bidRuntime.bid.Txs { |
There was a problem hiding this comment.
better to eliminate this for loop.
We can pass bidRuntime.bid.Txs into fillTransactions(..., bidRuntime.bid.Txs) directly.
// in fillTransactions(...)
for _, bigTx range bidRuntime.bid.Txs {
// check and remove from pendingPlainTxs & pendingBlobTxs
}
There was a problem hiding this comment.
hashset makes it simple
setunapo
approved these changes
Apr 11, 2024
zzzckck
approved these changes
Apr 11, 2024
unclezoro
approved these changes
Apr 11, 2024
This was referenced Apr 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: