R4R: unify error code and improve unittests #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
abelliumnt
commented
Jun 15, 2020
•
abelliumnt
commented
- Unify error code in tokenhub
- Add oracle sequence to support batch oracle
- Catch and analysis event data in tokenhub unittests
- Fix failed unit tests
abelliumnt
force-pushed
the
improve-unittests
branch
from
e0e06e0
to
9b6e096
Compare
abelliumnt
changed the title
abelliumnt
force-pushed
the
improve-unittests
branch
from
a0607a9
to
21887fe
Compare
abelliumnt
force-pushed
the
improve-unittests
branch
2 times, most recently
from
582105c
to
2f8238c
Compare
abelliumnt
force-pushed
the
improve-unittests
branch
from
2f8238c
to
b56be35
Compare
unclezoro
approved these changes
Jun 16, 2020
abelliumnt
pushed a commit
that referenced
this pull request
Jul 3, 2020
* improve tokenhub test * unify error code and fix failed unittests * add oracle sequence * modify miniToken checker
abelliumnt
pushed a commit
that referenced
this pull request
Jul 3, 2020
* improve tokenhub test * unify error code and fix failed unittests * add oracle sequence * modify miniToken checker
abelliumnt
pushed a commit
that referenced
this pull request
Jul 3, 2020
* improve tokenhub test * unify error code and fix failed unittests * add oracle sequence * modify miniToken checker
cosinlink
pushed a commit
that referenced
this pull request
Apr 27, 2022
* [R4R]: new implement of BEP-127 (#3) * feat: new implement of bep-127 and test * fix: review comments * fix: add re-init for validatorExtraSet * fix: template file sync * fix: validatorExtraSet should init at the same time as `maxNumOfMaintaining` init * modify config * fix: maintainInfo leak at next 24-hours * chores: add comment * fix: `isCurrentValidator` error before `validatorExtraSet` init * chore * test: add test case for BSCValidatorSet * test: add view test case for BSCValidatorSet * chore: modify comments * fix: numOfMaintaining modification on edge case * fix: review comments * test: add code size log * chore: optimize new ValidatorExtra * fix: numOfMaintaining edge case * fix: add exitMaintenance event * fix: add exitMaintenance event * chore * fix: remove unused code * chore * implement bep-131 * update ut * update logic of felony function * update the getMiningValidators function * update logic of the update maxNumOfCandidates function * fix calculating epoch number * update _exitMaintenance * fix comments * update readme * fix testcase on slash and validator contract * fix update maxNumOfMaintaining * fix: bug that validatorSet order was changed incorrectly while _felony in _forceMaintainingValidatorsExit, using numOfCabinets not init * feat: modify slots number * chore: rename var in loop * Fix audit report of BEP-127 and BEP-131 (#17) * fix: issue #BSC-007, add more comment to explain `enterMaintenanceHeight` check * fix: issue #BSC-001 and #BSC-002, #BSC-003, improve code to save gas * fix: issue #BSC-008, add comment to explain this * feat: sync template code with origin code * feat: rename len to validatorsNum * chore: modify comment for check * chore: sync template code * chore: add more comments to explain `24-hour period` * fix: k = 0 => k * fix: j = 0 => j * feat: sync template code for SlashIndicator.template Co-authored-by: gothery001 <gothery001> * fix: Bug fix that incorrectly modification of fixing audit report (#18) * fix: incorrectly modified `initValidatorExtraSet` * chore: sync template code Co-authored-by: gothery001 <gothery001> * fix: bug that slash count calculation problem while update validator set (#19) * feat: add more test case to test slashCount calc problem * fix: fix workValidatorCount calc incorrectly changed while updateValidatorSet * chores: sync tmeplate code * feat: add generate-qa script * feat: close gas report as default * feat: modify tests * chores: add more comments * chores: add more comments Co-authored-by: gothery001 <gothery001> Co-authored-by: dean65 <[email protected]> Co-authored-by: dean <[email protected]> Co-authored-by: realuncle <[email protected]> Co-authored-by: realuncle <[email protected]> Co-authored-by: realuncle <[email protected]> Co-authored-by: gothery001 <gothery001>
unclezoro
pushed a commit
that referenced
this pull request
Apr 28, 2022
* Implement bep-127 and bep-131 (#131) * [R4R]: new implement of BEP-127 (#3) * feat: new implement of bep-127 and test * fix: review comments * fix: add re-init for validatorExtraSet * fix: template file sync * fix: validatorExtraSet should init at the same time as `maxNumOfMaintaining` init * modify config * fix: maintainInfo leak at next 24-hours * chores: add comment * fix: `isCurrentValidator` error before `validatorExtraSet` init * chore * test: add test case for BSCValidatorSet * test: add view test case for BSCValidatorSet * chore: modify comments * fix: numOfMaintaining modification on edge case * fix: review comments * test: add code size log * chore: optimize new ValidatorExtra * fix: numOfMaintaining edge case * fix: add exitMaintenance event * fix: add exitMaintenance event * chore * fix: remove unused code * chore * implement bep-131 * update ut * update logic of felony function * update the getMiningValidators function * update logic of the update maxNumOfCandidates function * fix calculating epoch number * update _exitMaintenance * fix comments * update readme * fix testcase on slash and validator contract * fix update maxNumOfMaintaining * fix: bug that validatorSet order was changed incorrectly while _felony in _forceMaintainingValidatorsExit, using numOfCabinets not init * feat: modify slots number * chore: rename var in loop * Fix audit report of BEP-127 and BEP-131 (#17) * fix: issue #BSC-007, add more comment to explain `enterMaintenanceHeight` check * fix: issue #BSC-001 and #BSC-002, #BSC-003, improve code to save gas * fix: issue #BSC-008, add comment to explain this * feat: sync template code with origin code * feat: rename len to validatorsNum * chore: modify comment for check * chore: sync template code * chore: add more comments to explain `24-hour period` * fix: k = 0 => k * fix: j = 0 => j * feat: sync template code for SlashIndicator.template Co-authored-by: gothery001 <gothery001> * fix: Bug fix that incorrectly modification of fixing audit report (#18) * fix: incorrectly modified `initValidatorExtraSet` * chore: sync template code Co-authored-by: gothery001 <gothery001> * fix: bug that slash count calculation problem while update validator set (#19) * feat: add more test case to test slashCount calc problem * fix: fix workValidatorCount calc incorrectly changed while updateValidatorSet * chores: sync tmeplate code * feat: add generate-qa script * feat: close gas report as default * feat: modify tests * chores: add more comments * chores: add more comments Co-authored-by: gothery001 <gothery001> Co-authored-by: dean65 <[email protected]> Co-authored-by: dean <[email protected]> Co-authored-by: realuncle <[email protected]> Co-authored-by: realuncle <[email protected]> Co-authored-by: realuncle <[email protected]> Co-authored-by: gothery001 <gothery001> * chore: modify generate script line in package.json (#139) * chore: modify generate script line in package.json, generate latest genesis.json for mainnet * chore: modify readme Co-authored-by: cosinlink <cosinlink> Co-authored-by: Gothery <[email protected]> Co-authored-by: dean65 <[email protected]> Co-authored-by: dean <[email protected]> Co-authored-by: realuncle <[email protected]> Co-authored-by: realuncle <[email protected]> Co-authored-by: realuncle <[email protected]>
cosinlink
pushed a commit
that referenced
this pull request
Oct 7, 2022
* fix: incorrectly modified `initValidatorExtraSet` * chore: sync template code Co-authored-by: gothery001 <gothery001>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.