resolve comment

bnb-chain · Jun 1, 2020 · 1eeb193 · 1eeb193
1 parent 2c43b5d
commit 1eeb193
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 7 deletions.
diff --git a/contracts/RelayerIncentivize.sol b/contracts/RelayerIncentivize.sol
@@ -40,6 +40,11 @@ contract RelayerIncentivize is IRelayerIncentivize, System, IParamSubscriber {
 
   event paramChange(string key, bytes value);
 
+  modifier onlyInit() {
+    require(alreadyInit, "the contract not init yet");
+    _;
+  }
+
   function init() public {
     require(!alreadyInit, "already initialized");
     moleculeHeaderRelayer=MOLECULE_HEADER_RELAYER;
@@ -52,7 +57,7 @@ contract RelayerIncentivize is IRelayerIncentivize, System, IParamSubscriber {
   event LogDistributeCollectedReward(uint256 sequence, uint256 roundRewardForHeaderRelayer, uint256 roundRewardForTransferRelayer);
 
 
-  function addReward(address payable headerRelayerAddr, address payable caller) external onlyTokenHub override payable returns (bool) {
+  function addReward(address payable headerRelayerAddr, address payable caller) external onlyTokenHub onlyInit override payable returns (bool) {
 
     countInRound++;
 
@@ -89,7 +94,7 @@ contract RelayerIncentivize is IRelayerIncentivize, System, IParamSubscriber {
     return reward.mul(moleculeHeaderRelayer).div(denominatorHeaderRelayer);
   }
 
-  function distributeHeaderRelayerReward(address payable caller) internal returns (bool) {
+  function distributeHeaderRelayerReward(address payable caller) internal {
     uint256 totalReward = collectedRewardForHeaderRelayer;
 
     uint256 totalWeight=0;
@@ -120,7 +125,7 @@ contract RelayerIncentivize is IRelayerIncentivize, System, IParamSubscriber {
     delete headerRelayerAddressRecord;
   }
 
-  function distributeTransferRelayerReward(address payable caller) internal returns (bool) {
+  function distributeTransferRelayerReward(address payable caller) internal {
     uint256 totalReward = collectedRewardForTransferRelayer;
 
     uint256 totalWeight=0;

diff --git a/contracts/RelayerIncentivize.template b/contracts/RelayerIncentivize.template
@@ -40,6 +40,11 @@ contract RelayerIncentivize is IRelayerIncentivize, System, IParamSubscriber {
 
   event paramChange(string key, bytes value);
 
+  modifier onlyInit() {
+    require(alreadyInit, "the contract not init yet");
+    _;
+  }
+
   function init() public {
     require(!alreadyInit, "already initialized");
     moleculeHeaderRelayer=MOLECULE_HEADER_RELAYER;
@@ -54,7 +59,7 @@ contract RelayerIncentivize is IRelayerIncentivize, System, IParamSubscriber {
   {% if mock %}
   function addReward(address payable headerRelayerAddr, address payable caller) external override payable returns (bool) {
   {% else %}
-  function addReward(address payable headerRelayerAddr, address payable caller) external onlyTokenHub override payable returns (bool) {
+  function addReward(address payable headerRelayerAddr, address payable caller) external onlyTokenHub onlyInit override payable returns (bool) {
   {% endif %}
     countInRound++;
 
@@ -91,7 +96,7 @@ contract RelayerIncentivize is IRelayerIncentivize, System, IParamSubscriber {
     return reward.mul(moleculeHeaderRelayer).div(denominatorHeaderRelayer);
   }
 
-  function distributeHeaderRelayerReward(address payable caller) internal returns (bool) {
+  function distributeHeaderRelayerReward(address payable caller) internal {
     uint256 totalReward = collectedRewardForHeaderRelayer;
 
     uint256 totalWeight=0;
@@ -122,7 +127,7 @@ contract RelayerIncentivize is IRelayerIncentivize, System, IParamSubscriber {
     delete headerRelayerAddressRecord;
   }
 
-  function distributeTransferRelayerReward(address payable caller) internal returns (bool) {
+  function distributeTransferRelayerReward(address payable caller) internal {
     uint256 totalReward = collectedRewardForTransferRelayer;
 
     uint256 totalWeight=0;