[R4R]: Add upgrade manager #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yutianwu
requested review from
notatestuser,
ackratos,
darren-liu,
unclezoro and
rickyyangz
rickyyangz
reviewed
Mar 18, 2019
baseapp/baseapp.go
Outdated
| @@ -339,6 +344,8 @@ func (app *BaseApp) InitChain(req abci.RequestInitChain) (res abci.ResponseInitC | |||
| app.SetDeliverState(abci.Header{ChainID: req.ChainId}) | |||
| app.SetCheckState(abci.Header{ChainID: req.ChainId}) | |||
|
|
|||
| sdk.UpgradeMgr.SetHeight(1) | |||
darren-liu
requested changes
Mar 18, 2019
types/upgrade.go
Outdated
| return mgr.Height | ||
| } | ||
|
|
||
| func (mgr UpgradeManager) IsFixMatchEngineFork() bool { |
| @@ -506,6 +508,8 @@ func (app *BaseApp) BeginBlock(req abci.RequestBeginBlock) (res abci.ResponseBeg | |||
| )) | |||
| } | |||
|
|
|||
| sdk.UpgradeMgr.SetHeight(req.Header.Height) | |||
yutianwu
force-pushed
the
feature/add_upgrade
branch
from
b284af0 to
b04aa8f
Compare
darren-liu
approved these changes
Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add upgrade manager.
Add a global variable for current height. So we can access the height easily in places where we want if we decide to fork.
Rationale
Example
Changes
Notable changes:
Preflight checks
make build)make test)make integration_test)Already reviewed by
...
Related issues
... reference related issue #'s here ...