new slash mechanism #335
Merged
new slash mechanism #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanBSC
commented
Apr 17, 2023
unclezoro
reviewed
Apr 17, 2023
unclezoro
reviewed
Apr 17, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## develop #335 +/- ##
===========================================
- Coverage 46.14% 45.93% -0.21%
===========================================
Files 248 248
Lines 24087 24205 +118
===========================================
+ Hits 11114 11118 +4
- Misses 12307 12421 +114
Partials 666 666 |
unclezoro
reviewed
Apr 18, 2023
unclezoro
reviewed
Apr 18, 2023
buddh0
force-pushed
the
new_vote_slash
branch
3 times, most recently
from
6ffe958 to
e0f8f8e
Compare
unclezoro
approved these changes
Apr 19, 2023
|
need squash when merge |
pythonberg1997
approved these changes
Apr 20, 2023
buddh0
pushed a commit
that referenced
this pull request
Apr 25, 2023
* handle malicious vote slash as double sign * add TODO * add some info when slashing happens * fix use worng method to get seconds
buddh0
pushed a commit
that referenced
this pull request
Apr 25, 2023
* handle malicious vote slash as double sign * add TODO * add some info when slashing happens * fix use worng method to get seconds
This was referenced Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
introduce a new type of slashing for malicious vote.
it's trigged by crossschain package from systemscontracts in bsc and reuse params of double sign slashing, with following features:
a. one validator can't be slashed when it has been slashed for malicious vote previous and still in jail
b. validator can't escape from slashing by editing vote address after malicious vote
Rationale
Example
tested in new qa
Changes
NA