fix: fix the bug introduced by fixing the testnet syncing issue #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forcodedancing
approved these changes
Mar 23, 2023
|
LGTM |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## develop #331 +/- ##
===========================================
+ Coverage 46.70% 46.80% +0.09%
===========================================
Files 247 247
Lines 23824 23743 -81
===========================================
- Hits 11128 11112 -16
+ Misses 12029 11965 -64
+ Partials 667 666 -1 |
unclezoro
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr will fix the issue introduced by #320.
The overwriting of the config should only happen at block height 1 when the bsc upgrade is activated instead of after the bsc upgrade is activated.
The height
37501781is the block height the params changed after the previous fix.